[DebugInfo] Fix DebugLine::Prologue::getLength

The function a) returned 32-bits when in DWARF64, the PrologueLength
field is 64-bits in size, and b) didn't work for DWARF version 5.

Also deleted some related dead code. With this deletion, getLength is
itself dead, but another change is about to make use of it.

Reviewed by: probinson

Differential Revision: https://reviews.llvm.org/D73626

1 files changed, 23 insertions, 0 deletions

diff --git a/llvm/unittests/DebugInfo/DWARF/DWARFDebugLineTest.cpp b/llvm/unittests/DebugInfo/DWARF/DWARFDebugLineTest.cpp
index 89c28bc..bd2ae5c 100644
--- a/llvm/unittests/DebugInfo/DWARF/DWARFDebugLineTest.cpp
+++ b/llvm/unittests/DebugInfo/DWARF/DWARFDebugLineTest.cpp
@@ -235,6 +235,29 @@ TEST_F(DebugLineBasicFixture, GetOrParseLineTableAtInvalidOffsetAfterData) {
       "offset 0x00000001 is not a valid debug line section offset", 1);

 }

 

+TEST_P(DebugLineParameterisedFixture, PrologueGetLength) {

+  if (!setupGenerator(Version))

+    return;

+  LineTable &LT = Gen->addLineTable(Format);

+  DWARFDebugLine::Prologue Prologue = LT.createBasicPrologue();

+  LT.setPrologue(Prologue);

+  generate();

+

+  // + 10 for sizes of DWARF-32 unit length, version, prologue length.

+  uint64_t ExpectedLength = Prologue.PrologueLength + 10;

+  if (Version == 5)

+    // Add address and segment selector size fields.

+    ExpectedLength += 2;

+  if (Format == DWARF64)

+    // Unit length grows by 8, prologue length by 4.

+    ExpectedLength += 12;

+

+  auto ExpectedLineTable = Line.getOrParseLineTable(LineData, 0, *Context,

+                                                    nullptr, RecordRecoverable);

+  ASSERT_THAT_EXPECTED(ExpectedLineTable, Succeeded());

+  EXPECT_EQ((*ExpectedLineTable)->Prologue.getLength(), ExpectedLength);

+}

+

 TEST_P(DebugLineParameterisedFixture, GetOrParseLineTableValidTable) {

   if (!setupGenerator(Version))

     return;