diff options
author | Adrian Prantl <aprantl@apple.com> | 2024-09-18 14:54:49 -0700 |
---|---|---|
committer | Adrian Prantl <aprantl@apple.com> | 2024-09-20 17:08:36 -0700 |
commit | b44da2446b17aaa847bf76f81a01870917f8736b (patch) | |
tree | 3eb33031a6529f3c808081795472c36443479d31 /llvm/unittests/CodeGen | |
parent | f732157a9d067e4d300905c831a964222e0eadee (diff) | |
download | llvm-b44da2446b17aaa847bf76f81a01870917f8736b.zip llvm-b44da2446b17aaa847bf76f81a01870917f8736b.tar.gz llvm-b44da2446b17aaa847bf76f81a01870917f8736b.tar.bz2 |
[lldb] Change the implementation of Status to store an llvm::Error (NFC) (#106774)
(based on a conversation I had with @labath yesterday in
https://github.com/llvm/llvm-project/pull/106442)
Most APIs that currently vend a Status would be better served by
returning llvm::Expected<> instead. If possibles APIs should be
refactored to avoid Status. The only legitimate long-term uses of Status
are objects that need to store an error for a long time (which should be
questioned as a design decision, too).
This patch makes the transition to llvm::Error easier by making the
places that cannot switch to llvm::Error explicit: They are marked with
a call to Status::clone(). Every other API can and should be refactored
to use llvm::Expected. In the end Status should only be used in very few
places.
Whenever an unchecked Error is dropped by Status it logs this to the
verbose API channel.
Implementation notes:
This patch introduces two new kinds of error_category as well as new
llvm::Error types. Here is the mapping of lldb::ErrorType to
llvm::Errors:
```
(eErrorTypeInvalid)
eErrorTypeGeneric llvm::StringError
eErrorTypePOSIX llvm::ECError
eErrorTypeMachKernel MachKernelError
eErrorTypeExpression llvm::ErrorList<ExpressionError>
eErrorTypeWin32 Win32Error
```
Relanding with built-in cloning support for llvm::ECError, and support
for initializing a Windows error with a NO_ERROR error code.
Diffstat (limited to 'llvm/unittests/CodeGen')
0 files changed, 0 insertions, 0 deletions