diff options
author | Andrew Rogers <andrurogerz@gmail.com> | 2025-05-27 15:14:20 -0700 |
---|---|---|
committer | GitHub <noreply@github.com> | 2025-05-27 15:14:20 -0700 |
commit | d4d4a04771e183e6385919b72ba8206da87e1f9c (patch) | |
tree | 074ce8520dcaeb4d56913161b40ce9ba5f98b55e /llvm/unittests/Analysis | |
parent | 0354491bea04beb6d1db44f8ca522bfc597ab0d3 (diff) | |
download | llvm-d4d4a04771e183e6385919b72ba8206da87e1f9c.zip llvm-d4d4a04771e183e6385919b72ba8206da87e1f9c.tar.gz llvm-d4d4a04771e183e6385919b72ba8206da87e1f9c.tar.bz2 |
[llvm] annotate interfaces in llvm/Analysis for DLL export (#136623)
## Purpose
This patch is one in a series of code-mods that annotate LLVM’s public
interface for export. This patch annotates the `llvm/Analysis` library.
These annotations currently have no meaningful impact on the LLVM build;
however, they are a prerequisite to support an LLVM Windows DLL (shared
library) build.
## Background
This effort is tracked in #109483. Additional context is provided in
[this
discourse](https://discourse.llvm.org/t/psa-annotating-llvm-public-interface/85307),
and documentation for `LLVM_ABI` and related annotations is found in the
LLVM repo
[here](https://github.com/llvm/llvm-project/blob/main/llvm/docs/InterfaceExportAnnotations.rst).
The bulk of these changes were generated automatically using the
[Interface Definition Scanner (IDS)](https://github.com/compnerd/ids)
tool, followed formatting with `git clang-format`.
The following manual adjustments were also applied after running IDS on
Linux:
- Add `#include "llvm/Support/Compiler.h"` to files where it was not
auto-added by IDS due to no pre-existing block of include statements.
- Add `LLVM_TEMPLATE_ABI` and `LLVM_EXPORT_TEMPLATE` to exported
instantiated templates
- Add `LLVM_ABI` to a subset of private class methods and fields that
require export
- Add `LLVM_ABI` to a small number of symbols that require export but
are not declared in headers
## Validation
Local builds and tests to validate cross-platform compatibility. This
included llvm, clang, and lldb on the following configurations:
- Windows with MSVC
- Windows with Clang
- Linux with GCC
- Linux with Clang
- Darwin with Clang
Diffstat (limited to 'llvm/unittests/Analysis')
5 files changed, 17 insertions, 12 deletions
diff --git a/llvm/unittests/Analysis/AssumeBundleQueriesTest.cpp b/llvm/unittests/Analysis/AssumeBundleQueriesTest.cpp index 43c8b36..5fd2ecc 100644 --- a/llvm/unittests/Analysis/AssumeBundleQueriesTest.cpp +++ b/llvm/unittests/Analysis/AssumeBundleQueriesTest.cpp @@ -13,6 +13,7 @@ #include "llvm/IR/LLVMContext.h" #include "llvm/IR/Module.h" #include "llvm/Support/CommandLine.h" +#include "llvm/Support/Compiler.h" #include "llvm/Support/Regex.h" #include "llvm/Support/SourceMgr.h" #include "llvm/Transforms/Utils/AssumeBundleBuilder.h" @@ -22,7 +23,7 @@ using namespace llvm; namespace llvm { -extern cl::opt<bool> ShouldPreserveAllAttributes; +LLVM_ABI extern cl::opt<bool> ShouldPreserveAllAttributes; } // namespace llvm static void RunTest( diff --git a/llvm/unittests/Analysis/FunctionPropertiesAnalysisTest.cpp b/llvm/unittests/Analysis/FunctionPropertiesAnalysisTest.cpp index 574ad7c..0720d93 100644 --- a/llvm/unittests/Analysis/FunctionPropertiesAnalysisTest.cpp +++ b/llvm/unittests/Analysis/FunctionPropertiesAnalysisTest.cpp @@ -17,6 +17,7 @@ #include "llvm/IR/PassManager.h" #include "llvm/Passes/PassBuilder.h" #include "llvm/Passes/StandardInstrumentations.h" +#include "llvm/Support/Compiler.h" #include "llvm/Support/SourceMgr.h" #include "llvm/Transforms/Utils/Cloning.h" #include "gtest/gtest.h" @@ -25,9 +26,9 @@ using namespace llvm; namespace llvm { -extern cl::opt<bool> EnableDetailedFunctionProperties; -extern cl::opt<bool> BigBasicBlockInstructionThreshold; -extern cl::opt<bool> MediumBasicBlockInstrutionThreshold; +LLVM_ABI extern cl::opt<bool> EnableDetailedFunctionProperties; +LLVM_ABI extern cl::opt<bool> BigBasicBlockInstructionThreshold; +LLVM_ABI extern cl::opt<bool> MediumBasicBlockInstrutionThreshold; } // namespace llvm namespace { diff --git a/llvm/unittests/Analysis/IRSimilarityIdentifierTest.cpp b/llvm/unittests/Analysis/IRSimilarityIdentifierTest.cpp index b7ef23f..9edb21f 100644 --- a/llvm/unittests/Analysis/IRSimilarityIdentifierTest.cpp +++ b/llvm/unittests/Analysis/IRSimilarityIdentifierTest.cpp @@ -17,14 +17,15 @@ #include "llvm/IR/LLVMContext.h" #include "llvm/IR/Module.h" #include "llvm/Support/Allocator.h" +#include "llvm/Support/Compiler.h" #include "llvm/Support/SourceMgr.h" #include "gtest/gtest.h" using namespace llvm; using namespace IRSimilarity; -extern llvm::cl::opt<bool> UseNewDbgInfoFormat; -extern cl::opt<bool> UseNewDbgInfoFormat; +LLVM_ABI extern llvm::cl::opt<bool> UseNewDbgInfoFormat; +LLVM_ABI extern cl::opt<bool> UseNewDbgInfoFormat; static std::unique_ptr<Module> makeLLVMModule(LLVMContext &Context, StringRef ModuleStr) { diff --git a/llvm/unittests/Analysis/MemoryProfileInfoTest.cpp b/llvm/unittests/Analysis/MemoryProfileInfoTest.cpp index 170dca0..ee2342d 100644 --- a/llvm/unittests/Analysis/MemoryProfileInfoTest.cpp +++ b/llvm/unittests/Analysis/MemoryProfileInfoTest.cpp @@ -23,11 +23,12 @@ using namespace llvm; using namespace llvm::memprof; -extern cl::opt<float> MemProfLifetimeAccessDensityColdThreshold; -extern cl::opt<unsigned> MemProfAveLifetimeColdThreshold; -extern cl::opt<unsigned> MemProfMinAveLifetimeAccessDensityHotThreshold; -extern cl::opt<bool> MemProfUseHotHints; -extern cl::opt<bool> MemProfKeepAllNotColdContexts; +LLVM_ABI extern cl::opt<float> MemProfLifetimeAccessDensityColdThreshold; +LLVM_ABI extern cl::opt<unsigned> MemProfAveLifetimeColdThreshold; +LLVM_ABI extern cl::opt<unsigned> + MemProfMinAveLifetimeAccessDensityHotThreshold; +LLVM_ABI extern cl::opt<bool> MemProfUseHotHints; +LLVM_ABI extern cl::opt<bool> MemProfKeepAllNotColdContexts; namespace { diff --git a/llvm/unittests/Analysis/ProfileSummaryInfoTest.cpp b/llvm/unittests/Analysis/ProfileSummaryInfoTest.cpp index 519389d..45dc50e 100644 --- a/llvm/unittests/Analysis/ProfileSummaryInfoTest.cpp +++ b/llvm/unittests/Analysis/ProfileSummaryInfoTest.cpp @@ -18,13 +18,14 @@ #include "llvm/IR/MDBuilder.h" #include "llvm/IR/Module.h" #include "llvm/Support/CommandLine.h" +#include "llvm/Support/Compiler.h" #include "llvm/Support/DataTypes.h" #include "llvm/Support/FormatVariadic.h" #include "llvm/Support/SourceMgr.h" #include "llvm/Support/raw_ostream.h" #include "gtest/gtest.h" -extern llvm::cl::opt<bool> ScalePartialSampleProfileWorkingSetSize; +LLVM_ABI extern llvm::cl::opt<bool> ScalePartialSampleProfileWorkingSetSize; namespace llvm { namespace { |