diff options
| author | serge-sans-paille <sguelton@mozilla.com> | 2023-01-04 08:28:45 +0100 |
|---|---|---|
| committer | serge-sans-paille <sguelton@mozilla.com> | 2023-01-05 14:11:08 +0100 |
| commit | 38818b60c58c76ba89b990978cdfd2d7b6799260 (patch) | |
| tree | 63c85a12b00f87ec07dd8ad566970361e88f6fa4 /llvm/unittests/ADT/SmallVectorTest.cpp | |
| parent | 11be5cc00110eaff473cd41714120a11878326fc (diff) | |
| download | llvm-38818b60c58c76ba89b990978cdfd2d7b6799260.zip llvm-38818b60c58c76ba89b990978cdfd2d7b6799260.tar.gz llvm-38818b60c58c76ba89b990978cdfd2d7b6799260.tar.bz2 | |
Move from llvm::makeArrayRef to ArrayRef deduction guides - llvm/ part
Use deduction guides instead of helper functions.
The only non-automatic changes have been:
1. ArrayRef(some_uint8_pointer, 0) needs to be changed into ArrayRef(some_uint8_pointer, (size_t)0) to avoid an ambiguous call with ArrayRef((uint8_t*), (uint8_t*))
2. CVSymbol sym(makeArrayRef(symStorage)); needed to be rewritten as CVSymbol sym{ArrayRef(symStorage)}; otherwise the compiler is confused and thinks we have a (bad) function prototype. There was a few similar situation across the codebase.
3. ADL doesn't seem to work the same for deduction-guides and functions, so at some point the llvm namespace must be explicitly stated.
4. The "reference mode" of makeArrayRef(ArrayRef<T> &) that acts as no-op is not supported (a constructor cannot achieve that).
Per reviewers' comment, some useless makeArrayRef have been removed in the process.
This is a follow-up to https://reviews.llvm.org/D140896 that introduced
the deduction guides.
Differential Revision: https://reviews.llvm.org/D140955
Diffstat (limited to 'llvm/unittests/ADT/SmallVectorTest.cpp')
| -rw-r--r-- | llvm/unittests/ADT/SmallVectorTest.cpp | 12 |
1 files changed, 6 insertions, 6 deletions
diff --git a/llvm/unittests/ADT/SmallVectorTest.cpp b/llvm/unittests/ADT/SmallVectorTest.cpp index 62e6f433..fd3780a 100644 --- a/llvm/unittests/ADT/SmallVectorTest.cpp +++ b/llvm/unittests/ADT/SmallVectorTest.cpp @@ -1128,18 +1128,18 @@ TEST(SmallVectorTest, InitializerList) { SmallVector<int, 2> V1 = {}; EXPECT_TRUE(V1.empty()); V1 = {0, 0}; - EXPECT_TRUE(makeArrayRef(V1).equals({0, 0})); + EXPECT_TRUE(ArrayRef(V1).equals({0, 0})); V1 = {-1, -1}; - EXPECT_TRUE(makeArrayRef(V1).equals({-1, -1})); + EXPECT_TRUE(ArrayRef(V1).equals({-1, -1})); SmallVector<int, 2> V2 = {1, 2, 3, 4}; - EXPECT_TRUE(makeArrayRef(V2).equals({1, 2, 3, 4})); + EXPECT_TRUE(ArrayRef(V2).equals({1, 2, 3, 4})); V2.assign({4}); - EXPECT_TRUE(makeArrayRef(V2).equals({4})); + EXPECT_TRUE(ArrayRef(V2).equals({4})); V2.append({3, 2}); - EXPECT_TRUE(makeArrayRef(V2).equals({4, 3, 2})); + EXPECT_TRUE(ArrayRef(V2).equals({4, 3, 2})); V2.insert(V2.begin() + 1, 5); - EXPECT_TRUE(makeArrayRef(V2).equals({4, 5, 3, 2})); + EXPECT_TRUE(ArrayRef(V2).equals({4, 5, 3, 2})); } TEST(SmallVectorTest, ToVector) { |