diff options
author | Fangrui Song <maskray@google.com> | 2019-08-20 12:49:15 +0000 |
---|---|---|
committer | Fangrui Song <maskray@google.com> | 2019-08-20 12:49:15 +0000 |
commit | f13370280057c51cc98ed4a3f44fcb72e76944a3 (patch) | |
tree | fdcbedfa3e026e30d39ea1c7173bdc9ed2b057f3 /llvm/tools/llvm-readobj/llvm-readobj.cpp | |
parent | eb2211b352390a30718a497217e2ab8229fe9809 (diff) | |
download | llvm-f13370280057c51cc98ed4a3f44fcb72e76944a3.zip llvm-f13370280057c51cc98ed4a3f44fcb72e76944a3.tar.gz llvm-f13370280057c51cc98ed4a3f44fcb72e76944a3.tar.bz2 |
[llvm-readobj] Prepend argv[0] to error/warning messages
Summary:
Currently, we report:
error: ...
Prepend argv[0] (tool name):
llvm-readobj: error: ...
This is consistent with most GNU binutils/clang/lld, and gives a bit
more context in a long build log.
Reviewed By: grimar, jhenderson, rupprecht
Differential Revision: https://reviews.llvm.org/D66425
llvm-svn: 369377
Diffstat (limited to 'llvm/tools/llvm-readobj/llvm-readobj.cpp')
-rw-r--r-- | llvm/tools/llvm-readobj/llvm-readobj.cpp | 15 |
1 files changed, 9 insertions, 6 deletions
diff --git a/llvm/tools/llvm-readobj/llvm-readobj.cpp b/llvm/tools/llvm-readobj/llvm-readobj.cpp index bc24b6a..4133226 100644 --- a/llvm/tools/llvm-readobj/llvm-readobj.cpp +++ b/llvm/tools/llvm-readobj/llvm-readobj.cpp @@ -373,6 +373,8 @@ namespace opts { HelpResponse("\nPass @FILE as argument to read options from FILE.\n"); } // namespace opts +static StringRef ToolName; + namespace llvm { LLVM_ATTRIBUTE_NORETURN static void error(Twine Msg) { @@ -380,7 +382,7 @@ LLVM_ATTRIBUTE_NORETURN static void error(Twine Msg) { // proper place. fouts().flush(); errs() << "\n"; - WithColor::error(errs()) << Msg << "\n"; + WithColor::error(errs(), ToolName) << Msg << "\n"; exit(1); } @@ -401,11 +403,11 @@ void reportWarning(Error Err, StringRef Input) { // Flush the standard output to print the warning at a // proper place. fouts().flush(); - handleAllErrors(createFileError(Input, std::move(Err)), - [&](const ErrorInfoBase &EI) { - errs() << "\n"; - WithColor::warning(errs()) << EI.message() << "\n"; - }); + handleAllErrors( + createFileError(Input, std::move(Err)), [&](const ErrorInfoBase &EI) { + errs() << "\n"; + WithColor::warning(errs(), ToolName) << EI.message() << "\n"; + }); } LLVM_ATTRIBUTE_NORETURN void reportError(std::error_code EC, StringRef Input) { @@ -703,6 +705,7 @@ static void registerReadelfAliases() { int main(int argc, const char *argv[]) { InitLLVM X(argc, argv); + ToolName = argv[0]; // Register the target printer for --version. cl::AddExtraVersionPrinter(TargetRegistry::printRegisteredTargetsForVersion); |