diff options
| author | George Rimar <grimar@accesssoftek.com> | 2019-08-20 13:19:16 +0000 |
|---|---|---|
| committer | George Rimar <grimar@accesssoftek.com> | 2019-08-20 13:19:16 +0000 |
| commit | b232d5649d31b9bbb191c4a0e2ce10803a6d295c (patch) | |
| tree | 07e75cbe07c7c22e4ea286ebc420a02a5c0c3ace /llvm/tools/llvm-objdump/llvm-objdump.h | |
| parent | 028fe5af60fcfb84a7d842ab9cbadad27635090f (diff) | |
| download | llvm-b232d5649d31b9bbb191c4a0e2ce10803a6d295c.zip llvm-b232d5649d31b9bbb191c4a0e2ce10803a6d295c.tar.gz llvm-b232d5649d31b9bbb191c4a0e2ce10803a6d295c.tar.bz2 | |
[llvm-objdump] - Remove one of `report_error` functions and improve the error reporting.
One of the report_error functions was taking object::Archive::Child as an
argument. It feels excessive, this patch removes it and introduce a helper
function instead. Also I fixed a "TODO" in this patch what improved the message printed.
Differential revision: https://reviews.llvm.org/D66468
llvm-svn: 369382
Diffstat (limited to 'llvm/tools/llvm-objdump/llvm-objdump.h')
| -rw-r--r-- | llvm/tools/llvm-objdump/llvm-objdump.h | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/llvm/tools/llvm-objdump/llvm-objdump.h b/llvm/tools/llvm-objdump/llvm-objdump.h index eaa48b8..4d512d2 100644 --- a/llvm/tools/llvm-objdump/llvm-objdump.h +++ b/llvm/tools/llvm-objdump/llvm-objdump.h @@ -136,9 +136,6 @@ LLVM_ATTRIBUTE_NORETURN void report_error(Error E, StringRef File); LLVM_ATTRIBUTE_NORETURN void report_error(Error E, StringRef FileName, StringRef ArchiveName, StringRef ArchitectureName = StringRef()); -LLVM_ATTRIBUTE_NORETURN void -report_error(Error E, StringRef ArchiveName, const object::Archive::Child &C, - StringRef ArchitectureName = StringRef()); template <typename T, typename... Ts> T unwrapOrError(Expected<T> EO, Ts &&... Args) { @@ -147,6 +144,9 @@ T unwrapOrError(Expected<T> EO, Ts &&... Args) { report_error(EO.takeError(), std::forward<Ts>(Args)...); } +std::string getFileNameForError(const object::Archive::Child &C, + unsigned Index); + } // end namespace llvm #endif |