diff options
author | Heejin Ahn <aheejin@gmail.com> | 2025-01-23 14:47:15 -0800 |
---|---|---|
committer | GitHub <noreply@github.com> | 2025-01-23 14:47:15 -0800 |
commit | 25825d4ac9683010b0b921924cd5e244a82db1a3 (patch) | |
tree | 0288bf4e4fa0edaaf2abfc169805848d8915721c /llvm/tools/llvm-objcopy/llvm-objcopy.cpp | |
parent | 42043c423ff01d8d07f33aed76819d3b716bba0c (diff) | |
download | llvm-25825d4ac9683010b0b921924cd5e244a82db1a3.zip llvm-25825d4ac9683010b0b921924cd5e244a82db1a3.tar.gz llvm-25825d4ac9683010b0b921924cd5e244a82db1a3.tar.bz2 |
[WebAssembly] Enable Wasm EH features only once (#124042)
#122466 had an unexpected side effect that,
`EnableFeaturesForWasmEHSjLj` and `BanIncompatibleOptionsForWasmEHSjLj`
can be called multiple times now, every time a Wasm EH flag
(`-fwasm-exceptions`, `-wasm-enable-eh`, `-wasm-enable-sjlj`, ..) was
checked and handled. This resulted in unnecessarily adding the same
feature-enabling arguments multiple times to the command line, for
example, `-target-feature +exception-handling` could be added as many as
three times, which didn't cause any errors but unnecessary. Also we ran
`BanIncompatibleOptionsForWasmEHSjLj` more than once, which was harmless
but unnecessary.
This guards these functions with a static variable so that we only run
them once.
Diffstat (limited to 'llvm/tools/llvm-objcopy/llvm-objcopy.cpp')
0 files changed, 0 insertions, 0 deletions