diff options
author | Miloš Stojanović <Milos.Stojanovic@rt-rk.com> | 2020-01-17 14:28:54 +0100 |
---|---|---|
committer | Miloš Stojanović <Milos.Stojanovic@rt-rk.com> | 2020-01-20 16:19:13 +0100 |
commit | 24b7b99b7d68e1a234078eff639ccfbb7661eee5 (patch) | |
tree | 6682c99976c3a53d9a7090911fd464df2a538b07 /llvm/tools/llvm-exegesis/lib/Analysis.cpp | |
parent | 6ccebe004446b2b7362f96dd5cf7cbc2ed3facde (diff) | |
download | llvm-24b7b99b7d68e1a234078eff639ccfbb7661eee5.zip llvm-24b7b99b7d68e1a234078eff639ccfbb7661eee5.tar.gz llvm-24b7b99b7d68e1a234078eff639ccfbb7661eee5.tar.bz2 |
[llvm-exegesis][NFC] Disassociate snippet generators from benchmark runners
The addition of `inverse_throughput` mode highlighted the disjointedness
of snippet generators and benchmark runners because it used the
`UopsSnippetGenerator` with the `LatencyBenchmarkRunner`.
To keep the code consistent tie the snippet generators to
parallelization/serialization rather than their benchmark runners.
Renaming `LatencySnippetGenerator` -> `SerialSnippetGenerator`.
Renaming `UopsSnippetGenerator` -> `ParallelSnippetGenerator`.
Differential Revision: https://reviews.llvm.org/D72928
Diffstat (limited to 'llvm/tools/llvm-exegesis/lib/Analysis.cpp')
-rw-r--r-- | llvm/tools/llvm-exegesis/lib/Analysis.cpp | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/llvm/tools/llvm-exegesis/lib/Analysis.cpp b/llvm/tools/llvm-exegesis/lib/Analysis.cpp index 5bcccaf..5e9023b 100644 --- a/llvm/tools/llvm-exegesis/lib/Analysis.cpp +++ b/llvm/tools/llvm-exegesis/lib/Analysis.cpp @@ -244,9 +244,9 @@ Analysis::makePointsPerSchedClass() const { return Entries; } -// Uops repeat the same opcode over again. Just show this opcode and show the -// whole snippet only on hover. -static void writeUopsSnippetHtml(raw_ostream &OS, +// Parallel benchmarks repeat the same opcode multiple times. Just show this +// opcode and show the whole snippet only on hover. +static void writeParallelSnippetHtml(raw_ostream &OS, const std::vector<MCInst> &Instructions, const MCInstrInfo &InstrInfo) { if (Instructions.empty()) @@ -282,7 +282,7 @@ void Analysis::printPointHtml(const InstructionBenchmark &Point, break; case InstructionBenchmark::Uops: case InstructionBenchmark::InverseThroughput: - writeUopsSnippetHtml(OS, Point.Key.Instructions, *InstrInfo_); + writeParallelSnippetHtml(OS, Point.Key.Instructions, *InstrInfo_); break; default: llvm_unreachable("invalid mode"); |