aboutsummaryrefslogtreecommitdiff
path: root/llvm/tools/llvm-diff
diff options
context:
space:
mode:
authorMatthias Braun <matze@braunis.de>2017-01-28 02:02:38 +0000
committerMatthias Braun <matze@braunis.de>2017-01-28 02:02:38 +0000
commit8c209aa8779de57771b64896f805e14cc0016dcd (patch)
treeb3f7bc33dbb7be8ffe9a4f974253d6547b94ebdb /llvm/tools/llvm-diff
parentcfa5dc4a1dc2b7495aba96caba6fd2600c1ceb8a (diff)
downloadllvm-8c209aa8779de57771b64896f805e14cc0016dcd.zip
llvm-8c209aa8779de57771b64896f805e14cc0016dcd.tar.gz
llvm-8c209aa8779de57771b64896f805e14cc0016dcd.tar.bz2
Cleanup dump() functions.
We had various variants of defining dump() functions in LLVM. Normalize them (this should just consistently implement the things discussed in http://lists.llvm.org/pipermail/cfe-dev/2014-January/034323.html For reference: - Public headers should just declare the dump() method but not use LLVM_DUMP_METHOD or #if !defined(NDEBUG) || defined(LLVM_ENABLE_DUMP) - The definition of a dump method should look like this: #if !defined(NDEBUG) || defined(LLVM_ENABLE_DUMP) LLVM_DUMP_METHOD void MyClass::dump() { // print stuff to dbgs()... } #endif llvm-svn: 293359
Diffstat (limited to 'llvm/tools/llvm-diff')
-rw-r--r--llvm/tools/llvm-diff/DiffConsumer.cpp7
1 files changed, 4 insertions, 3 deletions
diff --git a/llvm/tools/llvm-diff/DiffConsumer.cpp b/llvm/tools/llvm-diff/DiffConsumer.cpp
index 9078013..e167750 100644
--- a/llvm/tools/llvm-diff/DiffConsumer.cpp
+++ b/llvm/tools/llvm-diff/DiffConsumer.cpp
@@ -15,6 +15,7 @@
#include "llvm/IR/Instructions.h"
#include "llvm/IR/Module.h"
#include "llvm/Support/ErrorHandling.h"
+#include "llvm/Support/Debug.h"
using namespace llvm;
@@ -195,17 +196,17 @@ void DiffConsumer::logd(const DiffLogBuilder &Log) {
switch (Log.getLineKind(I)) {
case DC_match:
out << " ";
- Log.getLeft(I)->dump();
+ Log.getLeft(I)->print(dbgs()); dbgs() << '\n';
//printValue(Log.getLeft(I), true);
break;
case DC_left:
out << "< ";
- Log.getLeft(I)->dump();
+ Log.getLeft(I)->print(dbgs()); dbgs() << '\n';
//printValue(Log.getLeft(I), true);
break;
case DC_right:
out << "> ";
- Log.getRight(I)->dump();
+ Log.getRight(I)->print(dbgs()); dbgs() << '\n';
//printValue(Log.getRight(I), false);
break;
}