diff options
author | Jordan Rupprecht <rupprecht@google.com> | 2018-12-20 00:57:06 +0000 |
---|---|---|
committer | Jordan Rupprecht <rupprecht@google.com> | 2018-12-20 00:57:06 +0000 |
commit | 16a0de2e555856444ff4037375bc8f9c024d36af (patch) | |
tree | f416ccd51ad4d1538b41738033e3d8daca63dd9b /llvm/tools/llvm-cov | |
parent | dff33c38e19775b44b7192dc58cf414c05ef6eaf (diff) | |
download | llvm-16a0de2e555856444ff4037375bc8f9c024d36af.zip llvm-16a0de2e555856444ff4037375bc8f9c024d36af.tar.gz llvm-16a0de2e555856444ff4037375bc8f9c024d36af.tar.bz2 |
[binutils] NFC: fix clang-tidy warning: use empty() instead of size() == 0
llvm-svn: 349710
Diffstat (limited to 'llvm/tools/llvm-cov')
-rw-r--r-- | llvm/tools/llvm-cov/CodeCoverage.cpp | 2 | ||||
-rw-r--r-- | llvm/tools/llvm-cov/SourceCoverageView.cpp | 2 | ||||
-rw-r--r-- | llvm/tools/llvm-cov/SourceCoverageViewHTML.cpp | 2 |
3 files changed, 3 insertions, 3 deletions
diff --git a/llvm/tools/llvm-cov/CodeCoverage.cpp b/llvm/tools/llvm-cov/CodeCoverage.cpp index 1dc6eed..728e00e 100644 --- a/llvm/tools/llvm-cov/CodeCoverage.cpp +++ b/llvm/tools/llvm-cov/CodeCoverage.cpp @@ -691,7 +691,7 @@ int CodeCoverageTool::run(Command Cmd, int argc, const char **argv) { PathRemapping = EquivPair; // If a demangler is supplied, check if it exists and register it. - if (DemanglerOpts.size()) { + if (!DemanglerOpts.empty()) { auto DemanglerPathOrErr = sys::findProgramByName(DemanglerOpts[0]); if (!DemanglerPathOrErr) { error("Could not find the demangler!", diff --git a/llvm/tools/llvm-cov/SourceCoverageView.cpp b/llvm/tools/llvm-cov/SourceCoverageView.cpp index 775322b..cebaf63 100644 --- a/llvm/tools/llvm-cov/SourceCoverageView.cpp +++ b/llvm/tools/llvm-cov/SourceCoverageView.cpp @@ -31,7 +31,7 @@ void CoveragePrinter::StreamDestructor::operator()(raw_ostream *OS) const { std::string CoveragePrinter::getOutputPath(StringRef Path, StringRef Extension, bool InToplevel, bool Relative) const { - assert(Extension.size() && "The file extension may not be empty"); + assert(!Extension.empty() && "The file extension may not be empty"); SmallString<256> FullPath; diff --git a/llvm/tools/llvm-cov/SourceCoverageViewHTML.cpp b/llvm/tools/llvm-cov/SourceCoverageViewHTML.cpp index acb67aa..3f730bb 100644 --- a/llvm/tools/llvm-cov/SourceCoverageViewHTML.cpp +++ b/llvm/tools/llvm-cov/SourceCoverageViewHTML.cpp @@ -54,7 +54,7 @@ std::string escape(StringRef Str, const CoverageViewOptions &Opts) { std::string tag(const std::string &Name, const std::string &Str, const std::string &ClassName = "") { std::string Tag = "<" + Name; - if (ClassName != "") + if (!ClassName.empty()) Tag += " class='" + ClassName + "'"; return Tag + ">" + Str + "</" + Name + ">"; } |