diff options
| author | Hans Wennborg <hans@hanshq.net> | 2017-09-18 23:08:42 +0000 |
|---|---|---|
| committer | Hans Wennborg <hans@hanshq.net> | 2017-09-18 23:08:42 +0000 |
| commit | 4de620ab3d4c5555c4e0702e5c904fe5791fe7b4 (patch) | |
| tree | 0f15af5f0f1502ecfaef46f63463d957439bc8bc /llvm/tools/llvm-cov/SourceCoverageView.cpp | |
| parent | 34a0dd5283a68f8389bfbf87223357de4091d2a3 (diff) | |
| download | llvm-4de620ab3d4c5555c4e0702e5c904fe5791fe7b4.zip llvm-4de620ab3d4c5555c4e0702e5c904fe5791fe7b4.tar.gz llvm-4de620ab3d4c5555c4e0702e5c904fe5791fe7b4.tar.bz2 | |
Revert r313400 "[DebugInfo] Insert DW_OP_deref when spilling indirect DBG_VALUEs"
This caused asserts in Chromium. See http://crbug.com/766261
> Summary:
> This comes up in optimized debug info for C++ programs that pass and
> return objects indirectly by address. In these programs,
> llvm.dbg.declare survives optimization, which causes us to emit indirect
> DBG_VALUE instructions. The fast register allocator knows to insert
> DW_OP_deref when spilling indirect DBG_VALUE instructions, but the
> LiveDebugVariables did not until this change.
>
> This fixes part of PR34513. I need to look into why this doesn't work at
> -O0 and I'll send follow up patches to handle that.
>
> Reviewers: aprantl, dblaikie, probinson
>
> Subscribers: qcolombet, hiraditya, llvm-commits
>
> Differential Revision: https://reviews.llvm.org/D37911
llvm-svn: 313589
Diffstat (limited to 'llvm/tools/llvm-cov/SourceCoverageView.cpp')
0 files changed, 0 insertions, 0 deletions