aboutsummaryrefslogtreecommitdiff
path: root/llvm/tools/llvm-cov/SourceCoverageView.cpp
diff options
context:
space:
mode:
authorVedant Kumar <vsk@apple.com>2017-09-18 23:37:27 +0000
committerVedant Kumar <vsk@apple.com>2017-09-18 23:37:27 +0000
commit25710a66a94d003944bd616706c8cacdd3b49e23 (patch)
tree2e6198a5d40595ab572384f7cc261900e63f6c21 /llvm/tools/llvm-cov/SourceCoverageView.cpp
parentd1e5e35660003f7f1a8ae62e30011306b4e3fd8e (diff)
downloadllvm-25710a66a94d003944bd616706c8cacdd3b49e23.zip
llvm-25710a66a94d003944bd616706c8cacdd3b49e23.tar.gz
llvm-25710a66a94d003944bd616706c8cacdd3b49e23.tar.bz2
[llvm-cov] Simplify code to find the first uncovered segment. NFC.
Now that that segment builder is guaranteed to produce segments in sorted order, we don't need a linear scan to get the right result. llvm-svn: 313595
Diffstat (limited to 'llvm/tools/llvm-cov/SourceCoverageView.cpp')
-rw-r--r--llvm/tools/llvm-cov/SourceCoverageView.cpp22
1 files changed, 8 insertions, 14 deletions
diff --git a/llvm/tools/llvm-cov/SourceCoverageView.cpp b/llvm/tools/llvm-cov/SourceCoverageView.cpp
index 08a1c75..79c2c69 100644
--- a/llvm/tools/llvm-cov/SourceCoverageView.cpp
+++ b/llvm/tools/llvm-cov/SourceCoverageView.cpp
@@ -125,22 +125,16 @@ LineCoverageStats::LineCoverageStats(
}
unsigned SourceCoverageView::getFirstUncoveredLineNo() {
- auto CheckIfUncovered = [](const coverage::CoverageSegment &S) {
- return S.HasCount && S.Count == 0;
- };
- // L is less than R if (1) it's an uncovered segment (has a 0 count), and (2)
- // either R is not an uncovered segment, or L has a lower line number than R.
const auto MinSegIt =
- std::min_element(CoverageInfo.begin(), CoverageInfo.end(),
- [CheckIfUncovered](const coverage::CoverageSegment &L,
- const coverage::CoverageSegment &R) {
- return (CheckIfUncovered(L) &&
- (!CheckIfUncovered(R) || (L.Line < R.Line)));
- });
- if (CheckIfUncovered(*MinSegIt))
- return (*MinSegIt).Line;
+ find_if(CoverageInfo, [](const coverage::CoverageSegment &S) {
+ return S.HasCount && S.Count == 0;
+ });
+
// There is no uncovered line, return zero.
- return 0;
+ if (MinSegIt == CoverageInfo.end())
+ return 0;
+
+ return (*MinSegIt).Line;
}
std::string SourceCoverageView::formatCount(uint64_t N) {