diff options
| author | Alexandre Ganea <alexandre.ganea@legionlabs.com> | 2022-02-08 17:39:13 -0500 |
|---|---|---|
| committer | Alexandre Ganea <alexandre.ganea@legionlabs.com> | 2022-02-08 19:12:15 -0500 |
| commit | bb8be26a7ec36d32c605a5a15b92b5614453391f (patch) | |
| tree | 84ff02b36428f904ba3b287681885b9fa645ca28 /llvm/lib/Support/TargetParser.cpp | |
| parent | 1e661e583d8406d5fce5269e803b287987332831 (diff) | |
| download | llvm-bb8be26a7ec36d32c605a5a15b92b5614453391f.zip llvm-bb8be26a7ec36d32c605a5a15b92b5614453391f.tar.gz llvm-bb8be26a7ec36d32c605a5a15b92b5614453391f.tar.bz2 | |
[LLD] Fix issue in HIP due to unspecified order of evaluation of the function object
This fixes the issue raised in https://reviews.llvm.org/D108850#3303452
Before C++17, the function object is evaluated in a unspecified order. In the following example: https://godbolt.org/z/8ao4vdsr7 the function object is either evaluated before or after the arguments, depending on the compiler. With MSVC and /std:c++14 the function object is evaluated after the arguments; with clang and gcc, it is evaluated before. With C++17, the function object is guaranteed to be evaluated before the arguments, see: https://riptutorial.com/cplusplus/example/19369/evaluation-order-of-function-arguments
In our case, the issue was that the `args` conversion to `ArrayRef` was evaluated before the lambda call `link`, which internally was calling `parseFlavor()`, which in turned modified `args`. We ended with an `ArrayRef` argument that reflected the previous contents of `args`.
Add coverage for `-flavor` which we didn't have before.
Differential Revision: https://reviews.llvm.org/D119278
Diffstat (limited to 'llvm/lib/Support/TargetParser.cpp')
0 files changed, 0 insertions, 0 deletions