diff options
| author | Vedant Kumar <vsk@apple.com> | 2020-05-29 22:47:08 -0700 |
|---|---|---|
| committer | Vedant Kumar <vsk@apple.com> | 2020-06-01 15:16:10 -0700 |
| commit | 776708b00bddb01f91b8d44f6853770966d335a5 (patch) | |
| tree | b0da3e3fecf61927682f93f0222d880f7d66f670 /llvm/lib/CodeGen/LiveDebugValues.cpp | |
| parent | a8f720925599f8e44366438f1ccb4b4e9d9375ae (diff) | |
| download | llvm-776708b00bddb01f91b8d44f6853770966d335a5.zip llvm-776708b00bddb01f91b8d44f6853770966d335a5.tar.gz llvm-776708b00bddb01f91b8d44f6853770966d335a5.tar.bz2 | |
[LiveDebugValues] Remove early-exit when testing regmasks, NFC
In transferRegisterDef, if the instruction has a regmask attached, we'll
check if any currently used register is clobbered by the regmask.
The early exit in this scan isn't necessary, costs a set lookup, and is
almost never taken [1]. Delete it.
[1]
http://lab.llvm.org:8080/coverage/coverage-reports/coverage/Users/buildslave/jenkins/workspace/coverage/llvm-project/llvm/lib/CodeGen/LiveDebugValues.cpp.html#L1136
Diffstat (limited to 'llvm/lib/CodeGen/LiveDebugValues.cpp')
| -rw-r--r-- | llvm/lib/CodeGen/LiveDebugValues.cpp | 4 |
1 files changed, 0 insertions, 4 deletions
diff --git a/llvm/lib/CodeGen/LiveDebugValues.cpp b/llvm/lib/CodeGen/LiveDebugValues.cpp index 6f0f9bd..85fb83d 100644 --- a/llvm/lib/CodeGen/LiveDebugValues.cpp +++ b/llvm/lib/CodeGen/LiveDebugValues.cpp @@ -1197,10 +1197,6 @@ void LiveDebugValues::transferRegisterDef( SmallVector<uint32_t, 32> UsedRegs; getUsedRegs(OpenRanges.getVarLocs(), UsedRegs); for (uint32_t Reg : UsedRegs) { - // The VarLocs residing in this register are already in the kill set. - if (DeadRegs.count(Reg)) - continue; - // Remove ranges of all clobbered registers. Register masks don't usually // list SP as preserved. Assume that call instructions never clobber SP, // because some backends (e.g., AArch64) never list SP in the regmask. |