diff options
author | Julian Lettner <jlettner@apple.com> | 2019-08-15 00:18:55 +0000 |
---|---|---|
committer | Julian Lettner <jlettner@apple.com> | 2019-08-15 00:18:55 +0000 |
commit | 399408a92f1dbbefeb708f718b0d8eb62dfa9f09 (patch) | |
tree | 317602ab47cb67e49146f4136f748a724e361e7a /llvm/lib/CodeGen/AsmPrinter/CodeViewDebug.cpp | |
parent | 5edd6843fa148ddc1b1a45b2bc66d1272a68d3c2 (diff) | |
download | llvm-399408a92f1dbbefeb708f718b0d8eb62dfa9f09.zip llvm-399408a92f1dbbefeb708f718b0d8eb62dfa9f09.tar.gz llvm-399408a92f1dbbefeb708f718b0d8eb62dfa9f09.tar.bz2 |
[sanitizer_common] Replace forkpty with posix_spawn on Darwin
On Darwin, we currently use forkpty to communicate with the "atos"
symbolizer. There are several problems that fork[pty] has, e.g. that
after fork, interceptors are still active and this sometimes causes
crashes or hangs. This is especially problematic for TSan, which uses
interceptors for OS-provided locks and mutexes, and even Libc functions
use those.
This patch replaces forkpty with posix_spawn on Darwin. Since
posix_spawn doesn't fork (at least on Darwin), the interceptors are not
a problem. Another benefit is that we'll handle post-fork failures (e.g.
sandbox disallows "exec") gracefully now.
Related revisions and previous attempts that were blocked by or had to
be revered due to test failures:
https://reviews.llvm.org/D48451
https://reviews.llvm.org/D40032
Reviewed By: kubamracek
Differential Revision: https://reviews.llvm.org/D65253
llvm-svn: 368947
Diffstat (limited to 'llvm/lib/CodeGen/AsmPrinter/CodeViewDebug.cpp')
0 files changed, 0 insertions, 0 deletions