diff options
| author | Sam McCall <sam.mccall@gmail.com> | 2018-11-06 09:28:23 +0000 |
|---|---|---|
| committer | Sam McCall <sam.mccall@gmail.com> | 2018-11-06 09:28:23 +0000 |
| commit | 80a3c561a7ea8072a984bc14a09b041667781f52 (patch) | |
| tree | 8602300ab38f9c87f10085be063fbbfb1b608e10 /llvm/lib/Bitcode/Reader | |
| parent | c6fcdd3b304b90fc2411dba7d661716d8c413cae (diff) | |
| download | llvm-80a3c561a7ea8072a984bc14a09b041667781f52.zip llvm-80a3c561a7ea8072a984bc14a09b041667781f52.tar.gz llvm-80a3c561a7ea8072a984bc14a09b041667781f52.tar.bz2 | |
[clang-tidy] run() doesn't update the SourceManager.
Summary:
By now the context's SourceManager is now initialized everywhere that
ClangTidyCheck::registerMatcher() is called, so the call from run() seems
entirely redundant, and indeed all the tests pass.
This solves a problem with embedding clang-tidy: if using a DiagnosticsEngine
which already has file state, re-setting its SourceManager (to the same value)
causes an assertion.
(There are other ways to solve this problem, but this is the simplest).
Reviewers: hokein, alexfh
Subscribers: xazax.hun, cfe-commits
Differential Revision: https://reviews.llvm.org/D54061
llvm-svn: 346219
Diffstat (limited to 'llvm/lib/Bitcode/Reader')
0 files changed, 0 insertions, 0 deletions