diff options
author | Chelsea Cassanova <chelsea_cassanova@apple.com> | 2025-07-23 18:10:16 -0700 |
---|---|---|
committer | GitHub <noreply@github.com> | 2025-07-23 18:10:16 -0700 |
commit | 68c8c8ceeba6da96189335236e3ec80a082e4d7b (patch) | |
tree | 5db7968f33f0ab7bf2e6ba1c3ef59d48c90b7bb0 /llvm/lib/Bitcode/Reader/BitcodeReader.cpp | |
parent | 22fef005225b129d73ade4ed995fc0ec0c7be044 (diff) | |
download | llvm-68c8c8ceeba6da96189335236e3ec80a082e4d7b.zip llvm-68c8c8ceeba6da96189335236e3ec80a082e4d7b.tar.gz llvm-68c8c8ceeba6da96189335236e3ec80a082e4d7b.tar.bz2 |
Reland "[lldb][RPC] Upstream lldb-rpc-gen tool" (#146969)" Attempt 2 (#148996)
Second attempt at relanding the lldb-rpc-gen tool. This should fix 2
issues:
- An assert that was hitting when building on Linux. The assert would
hit in the server source emitter, specifically when attemping to
determine the storage size for a return type is that is a pointer, but
isn't a const char *, const char ** or void pointer.
The assert would hit when attempting to generate
SBAttachInfo::GetProcessPluginName, which returns a const char *
(meaning it shouldn't have been in the code block for the assert at
all). The reason that it was hitting the assert when generating this
function is that lldb_rpc_gen::TypeIsConstCharPtr was returning false
for this function even though it did return a const char *. This was
happening because when checking the return type for a const char *,
TypeIsConstCharPtr would only check that the underlying type was a
signed char. This failed on Linux (but was fine on Darwin), as the
underlying type also needs to be checked for being an unsigned char.
- Cross compiling support
The build for lldb-rpc-gen had no support for cross compiling and as
such, the sources generated for lldb-rpc-gen would get compiled too
early in phase 2 when cross compiling, before the Clang toolchain was
built and this led to an error when trying to include stdlib files. This
reland splits this build into 2 by building the tool first and then
compiling the sources in the second stage of the cross-compiled build.
Original PR Description:
This commit upstreams the lldb-rpc-gen tool, a ClangTool that generates
the LLDB RPC client and server interfaces. This tool, as well as LLDB
RPC itself is built by default. If it needs to be disabled, put
-DLLDB_BUILD_LLDBRPC=OFF in your CMake invocation.
https://discourse.llvm.org/t/rfc-upstreaming-lldb-rpc/85804
Original PR Link:
github.com/llvm/llvm-project/pull/138031
Diffstat (limited to 'llvm/lib/Bitcode/Reader/BitcodeReader.cpp')
0 files changed, 0 insertions, 0 deletions