diff options
author | Raphael Isemann <teemperor@gmail.com> | 2019-08-15 07:29:53 +0000 |
---|---|---|
committer | Raphael Isemann <teemperor@gmail.com> | 2019-08-15 07:29:53 +0000 |
commit | 5c5408ce2c8c870a7365f18b9fb713c8d085f49b (patch) | |
tree | fa9b7cc93f35322e9b96d760eb9995d9226bf341 /llvm/lib/Analysis/ModuleSummaryAnalysis.cpp | |
parent | 0a3b1b26287a6a71cc525aeb41a42f7db8a2bd8d (diff) | |
download | llvm-5c5408ce2c8c870a7365f18b9fb713c8d085f49b.zip llvm-5c5408ce2c8c870a7365f18b9fb713c8d085f49b.tar.gz llvm-5c5408ce2c8c870a7365f18b9fb713c8d085f49b.tar.bz2 |
[lldb] Let LLDB depend on intrinsics_gen to fix non-deterministic module build failures
Summary:
When building with modules we currently fail randomly to build LLDB's modules and get error messages like below:
```
In file included from <module-includes>:1:
In file included from llvm-project/llvm/include/llvm/IR/Argument.h:18:
llvm-project/llvm/include/llvm/IR/Attributes.h:74:14: fatal error: 'llvm/IR/Attributes.inc' file not found
#include "llvm/IR/Attributes.inc"
^~~~~~~~~~~~~~~~~~~~~~~~
...
In file included from llvm-project/lldb/source/Plugins/ABI/SysV-arm/ABISysV_arm.cpp:9:
llvm-project/lldb/source/Plugins/ABI/SysV-arm/ABISysV_arm.h:12:10: fatal error: could not build module 'lldb_Wrapper'
```
The reason for this is that our source files can include Clang headers which in turn include files like Attributes.inc which
are generated by intrinsics_gen. However, it seems Clang can't express this dependency in its CMake code, so intrinsics_gen
is actually not guaranteed to be built before we start parsing LLDB source files and Clang headers. Clang worked around this
by letting all libraries depend on intrinsics_gen, which at least lets their builds pass.
As I haven't figured out how to solve these dependencies properly and I want to get the LLDB+Modules build green,
I suggest we copy Clang's hack until we figure out how to get Clang's dependencies right.
Reviewers: sgraenitz, aprantl, JDevlieghere
Reviewed By: JDevlieghere
Subscribers: mgorny, javed.absar, kristof.beyls, mgrang, lldb-commits
Tags: #lldb
Differential Revision: https://reviews.llvm.org/D66208
llvm-svn: 368975
Diffstat (limited to 'llvm/lib/Analysis/ModuleSummaryAnalysis.cpp')
0 files changed, 0 insertions, 0 deletions