aboutsummaryrefslogtreecommitdiff
path: root/llvm/lib/Analysis/ModuleSummaryAnalysis.cpp
diff options
context:
space:
mode:
authorMingming Liu <mingmingl@google.com>2021-12-10 05:39:55 +0000
committerminglotus-6 <mingmingl@google.com>2021-12-14 20:18:04 +0000
commit09a704c5efba2c07af5b457bf3afc5eb746f22c2 (patch)
treebd7f31d8db040ca8c9d8c4af81d63cfb1fd503ba /llvm/lib/Analysis/ModuleSummaryAnalysis.cpp
parent1695dd17524264a199d3731afe8e786bd1ce58c8 (diff)
downloadllvm-09a704c5efba2c07af5b457bf3afc5eb746f22c2.zip
llvm-09a704c5efba2c07af5b457bf3afc5eb746f22c2.tar.gz
llvm-09a704c5efba2c07af5b457bf3afc5eb746f22c2.tar.bz2
[LTO] Ignore unreachable virtual functions in WPD in hybrid LTO.
Differential Revision: https://reviews.llvm.org/D115492
Diffstat (limited to 'llvm/lib/Analysis/ModuleSummaryAnalysis.cpp')
-rw-r--r--llvm/lib/Analysis/ModuleSummaryAnalysis.cpp26
1 files changed, 24 insertions, 2 deletions
diff --git a/llvm/lib/Analysis/ModuleSummaryAnalysis.cpp b/llvm/lib/Analysis/ModuleSummaryAnalysis.cpp
index d808148..4039a44 100644
--- a/llvm/lib/Analysis/ModuleSummaryAnalysis.cpp
+++ b/llvm/lib/Analysis/ModuleSummaryAnalysis.cpp
@@ -234,6 +234,26 @@ static bool isNonVolatileStore(const Instruction *I) {
return false;
}
+// Returns true if `F` must be an unreachable function.
+//
+// Note if this helper function returns true, `F` is guaranteed
+// to be unreachable; if it returns false, `F` might still
+// be unreachable but not covered by this helper function.
+static bool mustBeUnreachableFunction(const Function &F) {
+ if (!F.empty()) {
+ const BasicBlock &entryBlock = F.getEntryBlock();
+ // A function must be unreachable if its entry block
+ // ends with an 'unreachable'.
+ if (!entryBlock.empty()) {
+ const Instruction *inst = &(*entryBlock.rbegin());
+ if (inst->getOpcode() == Instruction::Unreachable) {
+ return true;
+ }
+ }
+ }
+ return false;
+}
+
static void computeFunctionSummary(
ModuleSummaryIndex &Index, const Module &M, const Function &F,
BlockFrequencyInfo *BFI, ProfileSummaryInfo *PSI, DominatorTree &DT,
@@ -488,7 +508,8 @@ static void computeFunctionSummary(
// Don't try to import functions with noinline attribute.
F.getAttributes().hasFnAttr(Attribute::NoInline),
F.hasFnAttribute(Attribute::AlwaysInline),
- F.hasFnAttribute(Attribute::NoUnwind), MayThrow, HasUnknownCall};
+ F.hasFnAttribute(Attribute::NoUnwind), MayThrow, HasUnknownCall,
+ mustBeUnreachableFunction(F)};
std::vector<FunctionSummary::ParamAccess> ParamAccesses;
if (auto *SSI = GetSSICallback(F))
ParamAccesses = SSI->getParamAccesses(Index);
@@ -737,7 +758,8 @@ ModuleSummaryIndex llvm::buildModuleSummaryIndex(
F->hasFnAttribute(Attribute::AlwaysInline),
F->hasFnAttribute(Attribute::NoUnwind),
/* MayThrow */ true,
- /* HasUnknownCall */ true},
+ /* HasUnknownCall */ true,
+ /* MustBeUnreachable */ false},
/*EntryCount=*/0, ArrayRef<ValueInfo>{},
ArrayRef<FunctionSummary::EdgeTy>{},
ArrayRef<GlobalValue::GUID>{},