diff options
author | Roman Lebedev <lebedev.ri@gmail.com> | 2019-04-11 07:20:50 +0000 |
---|---|---|
committer | Roman Lebedev <lebedev.ri@gmail.com> | 2019-04-11 07:20:50 +0000 |
commit | fbb823891d73cb19d5d138920295f5bfe0e82e83 (patch) | |
tree | b2b7264576288f3e681581c67b0e5de7506d18a5 /llvm/docs/tutorial/MyFirstLanguageFrontend | |
parent | 58c080a3b12d0c7b4717f83370631a4f38283041 (diff) | |
download | llvm-fbb823891d73cb19d5d138920295f5bfe0e82e83.zip llvm-fbb823891d73cb19d5d138920295f5bfe0e82e83.tar.gz llvm-fbb823891d73cb19d5d138920295f5bfe0e82e83.tar.bz2 |
[llvm-exegesis] Fix serialization/deserialization of special NoRegister register (PR41448)
Summary:
A *lot* of instructions have this special register.
It seems this never really worked, but i finally noticed it only
because it happened to break for `CMOV16rm` instruction.
We serialized that register as "" (empty string), which is naturally
'ignored' during deserialization, so we re-create a `MCInst` with
too few operands.
And when we then happened to try to resolve variant sched class
for this mis-serialized instruction, and the variant predicate
tried to read an operand that was out of bounds since we got less operands,
we crashed.
Fixes [[ https://bugs.llvm.org/show_bug.cgi?id=41448 | PR41448 ]].
Reviewers: craig.topper, courbet
Reviewed By: courbet
Subscribers: tschuett, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D60517
llvm-svn: 358153
Diffstat (limited to 'llvm/docs/tutorial/MyFirstLanguageFrontend')
0 files changed, 0 insertions, 0 deletions