aboutsummaryrefslogtreecommitdiff
path: root/lldb
diff options
context:
space:
mode:
authorMichael Buch <michaelbuch12@gmail.com>2024-06-19 07:54:51 +0100
committerGitHub <noreply@github.com>2024-06-19 07:54:51 +0100
commitdadf960607bb429baebd3f523ce5b93260a154d2 (patch)
treeb4e8e14f42273b67ce40d31ef3f4aebc26b67c38 /lldb
parent7ef2bd4e447280015803cff7fc91ec4dd09cd4b3 (diff)
downloadllvm-dadf960607bb429baebd3f523ce5b93260a154d2.zip
llvm-dadf960607bb429baebd3f523ce5b93260a154d2.tar.gz
llvm-dadf960607bb429baebd3f523ce5b93260a154d2.tar.bz2
[lldb][ObjC] Don't query objective-c runtime for decls in C++ contexts (#95963)
Diffstat (limited to 'lldb')
-rw-r--r--lldb/source/Plugins/ExpressionParser/Clang/ClangASTSource.cpp2
-rw-r--r--lldb/test/API/lang/objcxx/objc-from-cpp-frames-without-debuginfo/TestObjCFromCppFramesWithoutDebugInfo.py7
-rw-r--r--lldb/test/Shell/Expr/TestObjCInCXXContext.test21
3 files changed, 29 insertions, 1 deletions
diff --git a/lldb/source/Plugins/ExpressionParser/Clang/ClangASTSource.cpp b/lldb/source/Plugins/ExpressionParser/Clang/ClangASTSource.cpp
index 82a7a2c..1fdd272 100644
--- a/lldb/source/Plugins/ExpressionParser/Clang/ClangASTSource.cpp
+++ b/lldb/source/Plugins/ExpressionParser/Clang/ClangASTSource.cpp
@@ -637,7 +637,7 @@ void ClangASTSource::FindExternalVisibleDecls(
FindDeclInModules(context, name);
}
- if (!context.m_found_type) {
+ if (!context.m_found_type && m_ast_context->getLangOpts().ObjC) {
FindDeclInObjCRuntime(context, name);
}
}
diff --git a/lldb/test/API/lang/objcxx/objc-from-cpp-frames-without-debuginfo/TestObjCFromCppFramesWithoutDebugInfo.py b/lldb/test/API/lang/objcxx/objc-from-cpp-frames-without-debuginfo/TestObjCFromCppFramesWithoutDebugInfo.py
index ef8d554..497c0dd 100644
--- a/lldb/test/API/lang/objcxx/objc-from-cpp-frames-without-debuginfo/TestObjCFromCppFramesWithoutDebugInfo.py
+++ b/lldb/test/API/lang/objcxx/objc-from-cpp-frames-without-debuginfo/TestObjCFromCppFramesWithoutDebugInfo.py
@@ -15,4 +15,11 @@ class TestObjCFromCppFramesWithoutDebugInfo(TestBase):
(_, process, _, _) = lldbutil.run_to_name_breakpoint(self, "main")
self.assertState(process.GetState(), lldb.eStateStopped)
+
+ # Tests that we can use builtin Objective-C identifiers.
self.expect("expr id", error=False)
+
+ # Tests that we can lookup Objective-C decls in the ObjC runtime plugin.
+ self.expect_expr(
+ "NSString *c; c == nullptr", result_value="true", result_type="bool"
+ )
diff --git a/lldb/test/Shell/Expr/TestObjCInCXXContext.test b/lldb/test/Shell/Expr/TestObjCInCXXContext.test
new file mode 100644
index 0000000..8537799
--- /dev/null
+++ b/lldb/test/Shell/Expr/TestObjCInCXXContext.test
@@ -0,0 +1,21 @@
+// UNSUPPORTED: system-linux, system-windows
+
+// Tests that we don't consult the the Objective-C runtime
+// plugin when in a purely C++ context.
+//
+// RUN: %clangxx_host %p/Inputs/objc-cast.cpp -g -o %t
+// RUN: %lldb %t \
+// RUN: -o "b main" -o run \
+// RUN: -o "expression --language objective-c -- NSString * a; a" \
+// RUN: -o "expression --language objective-c++ -- NSString * b; b" \
+// RUN: -o "expression NSString" \
+// RUN: 2>&1 | FileCheck %s
+
+// CHECK: (lldb) expression --language objective-c -- NSString * a; a
+// CHECK-NEXT: (NSString *){{.*}}= nil
+
+// CHECK: (lldb) expression --language objective-c++ -- NSString * b; b
+// CHECK-NEXT: (NSString *){{.*}}= nil
+
+// CHECK: (lldb) expression NSString
+// CHECK-NEXT: error:{{.*}} use of undeclared identifier 'NSString'