aboutsummaryrefslogtreecommitdiff
path: root/lldb
diff options
context:
space:
mode:
authorMichael Buch <michaelbuch12@gmail.com>2024-06-03 17:04:14 +0100
committerMichael Buch <michaelbuch12@gmail.com>2024-06-03 17:04:16 +0100
commitaad7874000faed77836e2bbd5c72af8776636f89 (patch)
tree40c452f1400444f0f636acd48cf1dfb77686d8f4 /lldb
parent6b7b05b55926f1fecae34312a89c4271def7aa3a (diff)
downloadllvm-aad7874000faed77836e2bbd5c72af8776636f89.zip
llvm-aad7874000faed77836e2bbd5c72af8776636f89.tar.gz
llvm-aad7874000faed77836e2bbd5c72af8776636f89.tar.bz2
[lldb][test][NFC] TestBreakpointSetRestart.py: split up assertion to determine which check specifically fails in CI
This test consistently fails on the public macOS ASAN CI (and isn't reproducible locally): ``` FAIL: test_breakpoint_set_restart_dwarf (TestBreakpointSetRestart.BreakpointSetRestart) ---------------------------------------------------------------------- Traceback (most recent call last): File "/Users/ec2-user/jenkins/workspace/llvm.org/lldb-cmake-sanitized/llvm-project/lldb/packages/Python/lldbsuite/test/lldbtest.py", line 1756, in test_method return attrvalue(self) File "/Users/ec2-user/jenkins/workspace/llvm.org/lldb-cmake-sanitized/llvm-project/lldb/packages/Python/lldbsuite/test/decorators.py", line 150, in wrapper return func(*args, **kwargs) File "/Users/ec2-user/jenkins/workspace/llvm.org/lldb-cmake-sanitized/llvm-project/lldb/test/API/functionalities/breakpoint/breakpoint_set_restart/TestBreakpointSetRestart.py", line 36, in test_breakpoint_set_restart self.assertTrue(bp.IsValid() and bp.GetNumLocations() == 1, VALID_BREAKPOINT) AssertionError: False is not true : Got a valid breakpoint ``` From this error we're not quite sure what about the breakpoint here is the problem. This patch splits up the assertion to narrow down the issue.
Diffstat (limited to 'lldb')
-rw-r--r--lldb/test/API/functionalities/breakpoint/breakpoint_set_restart/TestBreakpointSetRestart.py3
1 files changed, 2 insertions, 1 deletions
diff --git a/lldb/test/API/functionalities/breakpoint/breakpoint_set_restart/TestBreakpointSetRestart.py b/lldb/test/API/functionalities/breakpoint/breakpoint_set_restart/TestBreakpointSetRestart.py
index 3347f57..dac6a8f 100644
--- a/lldb/test/API/functionalities/breakpoint/breakpoint_set_restart/TestBreakpointSetRestart.py
+++ b/lldb/test/API/functionalities/breakpoint/breakpoint_set_restart/TestBreakpointSetRestart.py
@@ -33,7 +33,8 @@ class BreakpointSetRestart(TestBase):
bp = target.BreakpointCreateBySourceRegex(
self.BREAKPOINT_TEXT, lldb.SBFileSpec("main.cpp")
)
- self.assertTrue(bp.IsValid() and bp.GetNumLocations() == 1, VALID_BREAKPOINT)
+ self.assertTrue(bp.IsValid(), VALID_BREAKPOINT)
+ self.assertEqual(bp.GetNumLocations(), 1, VALID_BREAKPOINT)
while self.dbg.GetListener().WaitForEvent(2, event):
if lldb.SBProcess.GetStateFromEvent(