aboutsummaryrefslogtreecommitdiff
path: root/lldb
diff options
context:
space:
mode:
authorKazu Hirata <kazu@google.com>2021-10-23 20:41:46 -0700
committerKazu Hirata <kazu@google.com>2021-10-23 20:41:46 -0700
commit4ba9d9c84f4ce05eec341dc5f2d1c95934ab3d2c (patch)
treed127aa2ceec425f7f62b38470af69a9a05be5b41 /lldb
parenta709787cd988aaca847995bd08cc9348c9c6c956 (diff)
downloadllvm-4ba9d9c84f4ce05eec341dc5f2d1c95934ab3d2c.zip
llvm-4ba9d9c84f4ce05eec341dc5f2d1c95934ab3d2c.tar.gz
llvm-4ba9d9c84f4ce05eec341dc5f2d1c95934ab3d2c.tar.bz2
Use StringRef::contains (NFC)
Diffstat (limited to 'lldb')
-rw-r--r--lldb/source/Commands/CommandObjectWatchpoint.cpp2
-rw-r--r--lldb/source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp2
-rw-r--r--lldb/source/Plugins/Language/CPlusPlus/MSVCUndecoratedNameParser.cpp2
-rw-r--r--lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp6
-rw-r--r--lldb/tools/lldb-vscode/lldb-vscode.cpp2
5 files changed, 7 insertions, 7 deletions
diff --git a/lldb/source/Commands/CommandObjectWatchpoint.cpp b/lldb/source/Commands/CommandObjectWatchpoint.cpp
index d7a446f..9fbf036 100644
--- a/lldb/source/Commands/CommandObjectWatchpoint.cpp
+++ b/lldb/source/Commands/CommandObjectWatchpoint.cpp
@@ -56,7 +56,7 @@ static int32_t WithRSAIndex(llvm::StringRef Arg) {
uint32_t i;
for (i = 0; i < 4; ++i)
- if (Arg.find(RSA[i]) != llvm::StringRef::npos)
+ if (Arg.contains(RSA[i]))
return i;
return -1;
}
diff --git a/lldb/source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp b/lldb/source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp
index d9ab17e..a0cff3c 100644
--- a/lldb/source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp
+++ b/lldb/source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp
@@ -1309,7 +1309,7 @@ static bool FindFunctionInModule(ConstString &mangled_name,
llvm::Module *module, const char *orig_name) {
for (const auto &func : module->getFunctionList()) {
const StringRef &name = func.getName();
- if (name.find(orig_name) != StringRef::npos) {
+ if (name.contains(orig_name)) {
mangled_name.SetString(name);
return true;
}
diff --git a/lldb/source/Plugins/Language/CPlusPlus/MSVCUndecoratedNameParser.cpp b/lldb/source/Plugins/Language/CPlusPlus/MSVCUndecoratedNameParser.cpp
index b24bcc1..8ecf671 100644
--- a/lldb/source/Plugins/Language/CPlusPlus/MSVCUndecoratedNameParser.cpp
+++ b/lldb/source/Plugins/Language/CPlusPlus/MSVCUndecoratedNameParser.cpp
@@ -72,7 +72,7 @@ MSVCUndecoratedNameParser::MSVCUndecoratedNameParser(llvm::StringRef name) {
}
bool MSVCUndecoratedNameParser::IsMSVCUndecoratedName(llvm::StringRef name) {
- return name.find('`') != llvm::StringRef::npos;
+ return name.contains('`');
}
bool MSVCUndecoratedNameParser::ExtractContextAndIdentifier(
diff --git a/lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp b/lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp
index 9550cb5..a43f8c0 100644
--- a/lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp
+++ b/lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp
@@ -1543,17 +1543,17 @@ Status GDBRemoteCommunicationClient::GetMemoryRegionInfo(
region_info.GetRange().IsValid()) {
saw_permissions = true;
if (region_info.GetRange().Contains(addr)) {
- if (value.find('r') != llvm::StringRef::npos)
+ if (value.contains('r'))
region_info.SetReadable(MemoryRegionInfo::eYes);
else
region_info.SetReadable(MemoryRegionInfo::eNo);
- if (value.find('w') != llvm::StringRef::npos)
+ if (value.contains('w'))
region_info.SetWritable(MemoryRegionInfo::eYes);
else
region_info.SetWritable(MemoryRegionInfo::eNo);
- if (value.find('x') != llvm::StringRef::npos)
+ if (value.contains('x'))
region_info.SetExecutable(MemoryRegionInfo::eYes);
else
region_info.SetExecutable(MemoryRegionInfo::eNo);
diff --git a/lldb/tools/lldb-vscode/lldb-vscode.cpp b/lldb/tools/lldb-vscode/lldb-vscode.cpp
index 5c237c0..71bdcae 100644
--- a/lldb/tools/lldb-vscode/lldb-vscode.cpp
+++ b/lldb/tools/lldb-vscode/lldb-vscode.cpp
@@ -2747,7 +2747,7 @@ void request_setVariable(const llvm::json::Object &request) {
const auto variablesReference =
GetUnsigned(arguments, "variablesReference", 0);
llvm::StringRef name = GetString(arguments, "name");
- bool is_duplicated_variable_name = name.find(" @") != llvm::StringRef::npos;
+ bool is_duplicated_variable_name = name.contains(" @");
const auto value = GetString(arguments, "value");
// Set success to false just in case we don't find the variable by name