diff options
| author | Georgii Rymar <grimar@accesssoftek.com> | 2020-09-25 14:57:00 +0300 |
|---|---|---|
| committer | Georgii Rymar <grimar@accesssoftek.com> | 2020-09-28 11:28:53 +0300 |
| commit | ea0f66e84856519e08b255fd1010d7f07ad0dabd (patch) | |
| tree | ae9ab9c721b63ce292fc1f26fe6e4c4802c157e5 /lldb/unittests/ScriptInterpreter | |
| parent | 7e5a356d2bd232267aac2484519ac2c5658eca08 (diff) | |
| download | llvm-ea0f66e84856519e08b255fd1010d7f07ad0dabd.zip llvm-ea0f66e84856519e08b255fd1010d7f07ad0dabd.tar.gz llvm-ea0f66e84856519e08b255fd1010d7f07ad0dabd.tar.bz2 | |
[obj2yaml][yaml2obj] - Stop recognizing SHT_MIPS_ABIFLAGS on non-MIPS targets.
Currently we are always recognizing the `SHT_MIPS_ABIFLAGS` section,
even on non-MIPS targets.
The problem of doing this is briefly discussed in D88228 which does the same for `SHT_ARM_EXIDX`:
"The problem is that `SHT_ARM_EXIDX` shares the value with `SHT_X86_64_UNWIND (0x70000001U)`.
We might have other machine specific conflicts, e.g.
`SHT_ARM_ATTRIBUTES` vs `SHT_MSP430_ATTRIBUTES` vs `SHT_RISCV_ATTRIBUTES (0x70000003U)`."
I think we should only recognize target specific sections when the machine type
matches. I.e. `SHT_MIPS_*` should be recognized only on `MIPS`, `SHT_ARM_*`
only on `ARM` etc.
This patch stops recognizing `SHT_MIPS_ABIFLAGS` on `non-MIPS` targets.
Note: I had to update `ScalarEnumerationTraits<ELFYAML::MIPS_ISA>::enumeration`, because
otherwise test crashes, calling `llvm_unreachable`.
Differential revision: https://reviews.llvm.org/D88294
Diffstat (limited to 'lldb/unittests/ScriptInterpreter')
0 files changed, 0 insertions, 0 deletions