diff options
author | Niranjan Hasabnis <niranjan.hasabnis@intel.com> | 2024-06-27 01:24:05 -0700 |
---|---|---|
committer | GitHub <noreply@github.com> | 2024-06-27 09:24:05 +0100 |
commit | bdeee9b105b7f1e75adcbfbd43f884d4ddb1a612 (patch) | |
tree | e969d0fdf7a4e01a532b080982d38dbc05a48b91 /lldb/unittests/ScriptInterpreter/Python/PythonTestSuite.cpp | |
parent | 7a969ec1e114b6674c08e82ca048a3c4576bf0dd (diff) | |
download | llvm-bdeee9b105b7f1e75adcbfbd43f884d4ddb1a612.zip llvm-bdeee9b105b7f1e75adcbfbd43f884d4ddb1a612.tar.gz llvm-bdeee9b105b7f1e75adcbfbd43f884d4ddb1a612.tar.bz2 |
DLTI: Simplifying getDevicePropertyValue API by returning Attribute type value (#96706)
**Rationale**
- With the current flexibility of supporting any type of value, we will
need to offer type-specific APIs to fetch a value (e.g.,
`getDevicePropertyValueAsInt` for integer type,
`getDevicePropertyValueAsFloat` for float type, etc.) A single type of
value will eliminate this need.
- Current flexibility can also lead to typing errors when a user fetches
the value of a property using an API that is not consistent with the
type of the value.
**What is the change**
For following system description,
```
module attributes {
dlti.target_system_spec = #dlti.target_system_spec<
"CPU": #dlti.target_device_spec<
#dlti.dl_entry<"max_vector_op_width", 64.0 : f32>>,
"GPU": #dlti.target_device_spec<
#dlti.dl_entry<"max_vector_op_width", 128 : ui32>>
>} {}
```
a user no longer needs to use `getDevicePropertyValueAsInt` for
retrieving GPU's `max_vector_op_width` and
`getDevicePropertyValueAsFloat` for retrieving CPU's
`max_vector_op_width`. Instead it can be done with a uniform API of
`getDevicePropertyValue`.
Diffstat (limited to 'lldb/unittests/ScriptInterpreter/Python/PythonTestSuite.cpp')
0 files changed, 0 insertions, 0 deletions