diff options
author | Raphael Isemann <teemperor@gmail.com> | 2020-04-27 14:58:50 +0200 |
---|---|---|
committer | Raphael Isemann <teemperor@gmail.com> | 2020-05-08 19:25:02 +0200 |
commit | fcf10d19081029a0b6aa6933b72c63425425866a (patch) | |
tree | f76c0345b255a2ad4e55270f57691285b455f751 /lldb/unittests/ScriptInterpreter/Python/PythonDataObjectsTests.cpp | |
parent | 3b3e28a07cf5482db27581ecf23f6364b912f733 (diff) | |
download | llvm-fcf10d19081029a0b6aa6933b72c63425425866a.zip llvm-fcf10d19081029a0b6aa6933b72c63425425866a.tar.gz llvm-fcf10d19081029a0b6aa6933b72c63425425866a.tar.bz2 |
Reland [lldb][cmake] Also use local submodule visibility on Darwin
Relanding this as D79632 should fix the macOS tests with this option.
Original commit:
Summary:
Currently building LLVM on macOS and on other platforms with LLVM_ENABLE_MODULES is using different module flags,
which means that a passing modules build on macOS might fail on Linux and vice versa. -fmodules-local-submodule-visibility
is the mode that has clearer semantics and is closer to the actual C++ module standard, so let's make this the default everywhere.
We can still test building without local submodule visibility on an additional bot by just changing the respective CMake flag. However,
if building without local-submodule-visibility breaks we won't revert other commits and we won't loose LLDB's/Clang's test run
information.
Reviewers: aprantl, bruno, Bigcheese
Reviewed By: Bigcheese
Subscribers: abidh, dexonsmith, JDevlieghere, lldb-commits, mgorny, llvm-commits
Tags: #llvm, #lldb
Differential Revision: https://reviews.llvm.org/D74892
Diffstat (limited to 'lldb/unittests/ScriptInterpreter/Python/PythonDataObjectsTests.cpp')
0 files changed, 0 insertions, 0 deletions