diff options
| author | Georgii Rymar <grimar@accesssoftek.com> | 2020-11-19 18:23:27 +0300 |
|---|---|---|
| committer | Georgii Rymar <grimar@accesssoftek.com> | 2020-11-20 12:40:23 +0300 |
| commit | 343dceb8315b5c8d7844ec64e6e0931e6ba3655a (patch) | |
| tree | 07c06d845bc10b0e9cf6da906a4076b559347c9f /lldb/unittests/Process/gdb-remote/GDBRemoteCommunicationClientTest.cpp | |
| parent | da14ae23a54783a4bb2e20651af434530510e704 (diff) | |
| download | llvm-343dceb8315b5c8d7844ec64e6e0931e6ba3655a.zip llvm-343dceb8315b5c8d7844ec64e6e0931e6ba3655a.tar.gz llvm-343dceb8315b5c8d7844ec64e6e0931e6ba3655a.tar.bz2 | |
[llvm-readelf/obj] - Improve error reporting when dumping group sections.
Our code that dumps groups has 3 noticeable issues:
1) It uses `unwrapOrError` in many places.
2) It doesn't allow reporting unique warnings, because the `getGroups` helper is not
a member of `DumpStyle<ELFT>`.
3) It might just crash. See the comment for `StrTableOrErr->data() + Sym.st_name` line.
In this patch I am starting addressing these points.
For start I've converted one of `unwrapOrError` calls to a unique warning.
Differential revision: https://reviews.llvm.org/D91798
Diffstat (limited to 'lldb/unittests/Process/gdb-remote/GDBRemoteCommunicationClientTest.cpp')
0 files changed, 0 insertions, 0 deletions