diff options
author | Pavel Labath <labath@google.com> | 2018-05-14 14:52:47 +0000 |
---|---|---|
committer | Pavel Labath <labath@google.com> | 2018-05-14 14:52:47 +0000 |
commit | 2cb7cf8e87aa873e2a40fba2e93737556a44b477 (patch) | |
tree | 4b1dfa0afffcd63c0e7abc0a5e0dffe06141177b /lldb/unittests/Process/gdb-remote/GDBRemoteCommunicationClientTest.cpp | |
parent | 2a6afe5f87a08e1df0bed97edf8c4ab497dd9bff (diff) | |
download | llvm-2cb7cf8e87aa873e2a40fba2e93737556a44b477.zip llvm-2cb7cf8e87aa873e2a40fba2e93737556a44b477.tar.gz llvm-2cb7cf8e87aa873e2a40fba2e93737556a44b477.tar.bz2 |
FileSpec: Remove PathSyntax enum and use llvm version instead
Summary:
The llvm version of the enum has the same enumerators, with stlightly
different names, so this is mostly just a search&replace exercise. One
concrete benefit of this is that we can remove the function for
converting between the two enums.
To avoid typing llvm::sys::path::Style::windows everywhere I import the
enum into the FileSpec class, so it can be referenced as
FileSpec::Style::windows.
Reviewers: zturner, clayborg
Subscribers: lldb-commits
Differential Revision: https://reviews.llvm.org/D46753
llvm-svn: 332247
Diffstat (limited to 'lldb/unittests/Process/gdb-remote/GDBRemoteCommunicationClientTest.cpp')
-rw-r--r-- | lldb/unittests/Process/gdb-remote/GDBRemoteCommunicationClientTest.cpp | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/lldb/unittests/Process/gdb-remote/GDBRemoteCommunicationClientTest.cpp b/lldb/unittests/Process/gdb-remote/GDBRemoteCommunicationClientTest.cpp index 186175fe..420e011 100644 --- a/lldb/unittests/Process/gdb-remote/GDBRemoteCommunicationClientTest.cpp +++ b/lldb/unittests/Process/gdb-remote/GDBRemoteCommunicationClientTest.cpp @@ -169,14 +169,14 @@ TEST_F(GDBRemoteCommunicationClientTest, GetModulesInfo) { llvm::Triple triple("i386-pc-linux"); FileSpec file_specs[] = { - FileSpec("/foo/bar.so", false, FileSpec::ePathSyntaxPosix), - FileSpec("/foo/baz.so", false, FileSpec::ePathSyntaxPosix), + FileSpec("/foo/bar.so", false, FileSpec::Style::posix), + FileSpec("/foo/baz.so", false, FileSpec::Style::posix), // This is a bit dodgy but we currently depend on GetModulesInfo not // performing denormalization. It can go away once the users // (DynamicLoaderPOSIXDYLD, at least) correctly set the path syntax for // the FileSpecs they create. - FileSpec("/foo/baw.so", false, FileSpec::ePathSyntaxWindows), + FileSpec("/foo/baw.so", false, FileSpec::Style::windows), }; std::future<llvm::Optional<std::vector<ModuleSpec>>> async_result = std::async(std::launch::async, @@ -202,7 +202,7 @@ TEST_F(GDBRemoteCommunicationClientTest, GetModulesInfo) { TEST_F(GDBRemoteCommunicationClientTest, GetModulesInfo_UUID20) { llvm::Triple triple("i386-pc-linux"); - FileSpec file_spec("/foo/bar.so", false, FileSpec::ePathSyntaxPosix); + FileSpec file_spec("/foo/bar.so", false, FileSpec::Style::posix); std::future<llvm::Optional<std::vector<ModuleSpec>>> async_result = std::async(std::launch::async, [&] { return client.GetModulesInfo(file_spec, triple); }); @@ -225,7 +225,7 @@ TEST_F(GDBRemoteCommunicationClientTest, GetModulesInfo_UUID20) { TEST_F(GDBRemoteCommunicationClientTest, GetModulesInfoInvalidResponse) { llvm::Triple triple("i386-pc-linux"); - FileSpec file_spec("/foo/bar.so", false, FileSpec::ePathSyntaxPosix); + FileSpec file_spec("/foo/bar.so", false, FileSpec::Style::posix); const char *invalid_responses[] = { // no UUID |