aboutsummaryrefslogtreecommitdiff
path: root/lldb/source/Plugins/ScriptInterpreter/Python
diff options
context:
space:
mode:
authorDavid Spickett <david.spickett@linaro.org>2025-01-29 09:58:52 +0000
committerDavid Spickett <david.spickett@linaro.org>2025-01-29 09:59:34 +0000
commitdb567eaca07133a374991153635a119d9eec066b (patch)
tree9380f04d22118d022f99c31a313d8fe6c64f6d70 /lldb/source/Plugins/ScriptInterpreter/Python
parent9ea64dd8781328d831d7c69a586f0c84dece1c11 (diff)
downloadllvm-db567eaca07133a374991153635a119d9eec066b.zip
llvm-db567eaca07133a374991153635a119d9eec066b.tar.gz
llvm-db567eaca07133a374991153635a119d9eec066b.tar.bz2
[lldb][NFC] Format part of ScriptInterpreterPython.cpp
Was flagged in https://github.com/llvm/llvm-project/pull/124735 but done separately so it didn't get in the way of that.
Diffstat (limited to 'lldb/source/Plugins/ScriptInterpreter/Python')
-rw-r--r--lldb/source/Plugins/ScriptInterpreter/Python/ScriptInterpreterPython.cpp14
1 files changed, 8 insertions, 6 deletions
diff --git a/lldb/source/Plugins/ScriptInterpreter/Python/ScriptInterpreterPython.cpp b/lldb/source/Plugins/ScriptInterpreter/Python/ScriptInterpreterPython.cpp
index e78e606..f4efb00 100644
--- a/lldb/source/Plugins/ScriptInterpreter/Python/ScriptInterpreterPython.cpp
+++ b/lldb/source/Plugins/ScriptInterpreter/Python/ScriptInterpreterPython.cpp
@@ -152,12 +152,14 @@ public:
private:
void InitializeThreadsPrivate() {
-// Since Python 3.7 `Py_Initialize` calls `PyEval_InitThreads` inside itself,
-// so there is no way to determine whether the embedded interpreter
-// was already initialized by some external code. `PyEval_ThreadsInitialized`
-// would always return `true` and `PyGILState_Ensure/Release` flow would be
-// executed instead of unlocking GIL with `PyEval_SaveThread`. When
-// an another thread calls `PyGILState_Ensure` it would get stuck in deadlock.
+ // Since Python 3.7 `Py_Initialize` calls `PyEval_InitThreads` inside
+ // itself, so there is no way to determine whether the embedded interpreter
+ // was already initialized by some external code.
+ // `PyEval_ThreadsInitialized` would always return `true` and
+ // `PyGILState_Ensure/Release` flow would be executed instead of unlocking
+ // GIL with `PyEval_SaveThread`. When an another thread calls
+ // `PyGILState_Ensure` it would get stuck in deadlock.
+
// The only case we should go further and acquire the GIL: it is unlocked.
if (PyGILState_Check())
return;