diff options
author | Jonas Devlieghere <jonas@devlieghere.com> | 2024-10-24 20:20:48 -0700 |
---|---|---|
committer | GitHub <noreply@github.com> | 2024-10-24 20:20:48 -0700 |
commit | b852fb1ec5fa15f0b913cc4988cbd09239b19904 (patch) | |
tree | c8dc1b066b78d50c87b2fb7da1aa4d3e1ce865ff /lldb/source/Plugins/ScriptInterpreter/Python | |
parent | a31ce36f568723ffa5b4155d0ba009403ccd0d9e (diff) | |
download | llvm-b852fb1ec5fa15f0b913cc4988cbd09239b19904.zip llvm-b852fb1ec5fa15f0b913cc4988cbd09239b19904.tar.gz llvm-b852fb1ec5fa15f0b913cc4988cbd09239b19904.tar.bz2 |
[lldb] Move ValueObject into its own library (NFC) (#113393)
ValueObject is part of lldbCore for historical reasons, but conceptually
it deserves to be its own library. This does introduce a (link-time) circular
dependency between lldbCore and lldbValueObject, which is unfortunate
but probably unavoidable because so many things in LLDB rely on
ValueObject. We already have cycles and these libraries are never built
as dylibs so while this doesn't improve the situation, it also doesn't
make things worse.
The header includes were updated with the following command:
```
find . -type f -exec sed -i.bak "s%include \"lldb/Core/ValueObject%include \"lldb/ValueObject/ValueObject%" '{}' \;
```
Diffstat (limited to 'lldb/source/Plugins/ScriptInterpreter/Python')
-rw-r--r-- | lldb/source/Plugins/ScriptInterpreter/Python/CMakeLists.txt | 1 | ||||
-rw-r--r-- | lldb/source/Plugins/ScriptInterpreter/Python/ScriptInterpreterPython.cpp | 2 |
2 files changed, 2 insertions, 1 deletions
diff --git a/lldb/source/Plugins/ScriptInterpreter/Python/CMakeLists.txt b/lldb/source/Plugins/ScriptInterpreter/Python/CMakeLists.txt index 7523d65..fd3118a 100644 --- a/lldb/source/Plugins/ScriptInterpreter/Python/CMakeLists.txt +++ b/lldb/source/Plugins/ScriptInterpreter/Python/CMakeLists.txt @@ -33,6 +33,7 @@ add_lldb_library(lldbPluginScriptInterpreterPython PLUGIN lldbHost lldbInterpreter lldbTarget + lldbValueObject lldbPluginScriptInterpreterPythonInterfaces ${Python3_LIBRARIES} ${LLDB_LIBEDIT_LIBS} diff --git a/lldb/source/Plugins/ScriptInterpreter/Python/ScriptInterpreterPython.cpp b/lldb/source/Plugins/ScriptInterpreter/Python/ScriptInterpreterPython.cpp index db1a10e..7cc38da 100644 --- a/lldb/source/Plugins/ScriptInterpreter/Python/ScriptInterpreterPython.cpp +++ b/lldb/source/Plugins/ScriptInterpreter/Python/ScriptInterpreterPython.cpp @@ -29,7 +29,6 @@ #include "lldb/Core/Debugger.h" #include "lldb/Core/PluginManager.h" #include "lldb/Core/ThreadedCommunication.h" -#include "lldb/Core/ValueObject.h" #include "lldb/DataFormatters/TypeSummary.h" #include "lldb/Host/FileSystem.h" #include "lldb/Host/HostInfo.h" @@ -41,6 +40,7 @@ #include "lldb/Utility/Instrumentation.h" #include "lldb/Utility/LLDBLog.h" #include "lldb/Utility/Timer.h" +#include "lldb/ValueObject/ValueObject.h" #include "llvm/ADT/STLExtras.h" #include "llvm/ADT/StringRef.h" #include "llvm/Support/Error.h" |