aboutsummaryrefslogtreecommitdiff
path: root/lldb/source/Plugins/ScriptInterpreter/Python
diff options
context:
space:
mode:
authorMichael Maitland <michaeltmaitland@gmail.com>2024-09-20 07:01:17 -0700
committerMichael Maitland <michaeltmaitland@gmail.com>2024-09-20 07:01:17 -0700
commit9c5ad62e7440423fbcd2d84c8f0347a5f000400e (patch)
tree85c2231b56ef6093d6991805d91afbfa8be646a9 /lldb/source/Plugins/ScriptInterpreter/Python
parent57b12e8fbc9bb29ebe8f9d2a0f2c5085b38c2454 (diff)
downloadllvm-9c5ad62e7440423fbcd2d84c8f0347a5f000400e.zip
llvm-9c5ad62e7440423fbcd2d84c8f0347a5f000400e.tar.gz
llvm-9c5ad62e7440423fbcd2d84c8f0347a5f000400e.tar.bz2
Revert "[RISCV][GISEL] Introduce the RISCVPostLegalizerLowering pass (#108991)"
This reverts commit 64972834c193632cbc47e54c0f0c721636b077e6. Based on the discussions in #108991 that happened post merge, we have decided to remove this pass in favor of generating `RISCV::G_*` opcodes in the legalizer. We may reconsider moving that code elsewhere in the future so that we can do a better job during generic combines. We don't feel that doing it in instruciton selection is the right decision today. Firstly, it requires us to manually do regbankselect on the newly introduced instructions. Secondly, it is more difficult to test since the test output will contain whatever `RISCV::G_*` instructions select to (instead of `RISCV::G_*`). My personal opinion is that the legalizer pass can be split into an early legalizer and a late legalizer, both before regbankselect. The first legalizer would not introduce target specific generic opcodes and the generic combiner would run after it. The second legalizer would introduce the target specific generic opcodes. I think this approach is better than the lowerer because the legalizer guarantees that whatever we lower to is legal, and apparently because it is more performant at compared to the lowerer (although, I'm not sure how true this is).
Diffstat (limited to 'lldb/source/Plugins/ScriptInterpreter/Python')
0 files changed, 0 insertions, 0 deletions