diff options
| author | Youngsuk Kim <joseph942010@gmail.com> | 2024-09-16 00:26:51 -0400 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2024-09-16 00:26:51 -0400 |
| commit | d7796855b87911b8ae6c726ab5df4949f173dbd2 (patch) | |
| tree | 5554fd0a1cfbcfa29e8276f329ac0e49b46be3f4 /lldb/source/Commands/CommandObjectRegexCommand.cpp | |
| parent | 4fdccd346bb5969707845762d3c27f4806d46de8 (diff) | |
| download | llvm-d7796855b87911b8ae6c726ab5df4949f173dbd2.zip llvm-d7796855b87911b8ae6c726ab5df4949f173dbd2.tar.gz llvm-d7796855b87911b8ae6c726ab5df4949f173dbd2.tar.bz2 | |
[lldb] Nits on uses of llvm::raw_string_ostream (NFC) (#108745)
As specified in the docs,
1) raw_string_ostream is always unbuffered and
2) the underlying buffer may be used directly
( 65b13610a5226b84889b923bae884ba395ad084d for further reference )
* Don't call raw_string_ostream::flush(), which is essentially a no-op.
* Avoid unneeded calls to raw_string_ostream::str(), to avoid excess
indirection.
Diffstat (limited to 'lldb/source/Commands/CommandObjectRegexCommand.cpp')
| -rw-r--r-- | lldb/source/Commands/CommandObjectRegexCommand.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/lldb/source/Commands/CommandObjectRegexCommand.cpp b/lldb/source/Commands/CommandObjectRegexCommand.cpp index f638d70..7e27915 100644 --- a/lldb/source/Commands/CommandObjectRegexCommand.cpp +++ b/lldb/source/Commands/CommandObjectRegexCommand.cpp @@ -51,7 +51,7 @@ llvm::Expected<std::string> CommandObjectRegexCommand::SubstituteVariables( output << part; } - return output.str(); + return buffer; } void CommandObjectRegexCommand::DoExecute(llvm::StringRef command, |