aboutsummaryrefslogtreecommitdiff
path: root/lldb/source/Commands/CommandObjectLog.cpp
diff options
context:
space:
mode:
authorYoungsuk Kim <joseph942010@gmail.com>2024-09-16 00:26:51 -0400
committerGitHub <noreply@github.com>2024-09-16 00:26:51 -0400
commitd7796855b87911b8ae6c726ab5df4949f173dbd2 (patch)
tree5554fd0a1cfbcfa29e8276f329ac0e49b46be3f4 /lldb/source/Commands/CommandObjectLog.cpp
parent4fdccd346bb5969707845762d3c27f4806d46de8 (diff)
downloadllvm-d7796855b87911b8ae6c726ab5df4949f173dbd2.zip
llvm-d7796855b87911b8ae6c726ab5df4949f173dbd2.tar.gz
llvm-d7796855b87911b8ae6c726ab5df4949f173dbd2.tar.bz2
[lldb] Nits on uses of llvm::raw_string_ostream (NFC) (#108745)
As specified in the docs, 1) raw_string_ostream is always unbuffered and 2) the underlying buffer may be used directly ( 65b13610a5226b84889b923bae884ba395ad084d for further reference ) * Don't call raw_string_ostream::flush(), which is essentially a no-op. * Avoid unneeded calls to raw_string_ostream::str(), to avoid excess indirection.
Diffstat (limited to 'lldb/source/Commands/CommandObjectLog.cpp')
-rw-r--r--lldb/source/Commands/CommandObjectLog.cpp8
1 files changed, 4 insertions, 4 deletions
diff --git a/lldb/source/Commands/CommandObjectLog.cpp b/lldb/source/Commands/CommandObjectLog.cpp
index 9eb68dd..5fb2dfa 100644
--- a/lldb/source/Commands/CommandObjectLog.cpp
+++ b/lldb/source/Commands/CommandObjectLog.cpp
@@ -204,7 +204,7 @@ protected:
channel, args.GetArgumentArrayRef(), log_file, m_options.log_options,
m_options.buffer_size.GetCurrentValue(), m_options.handler,
error_stream);
- result.GetErrorStream() << error_stream.str();
+ result.GetErrorStream() << error;
if (success)
result.SetStatus(eReturnStatusSuccessFinishNoResult);
@@ -273,7 +273,7 @@ protected:
if (Log::DisableLogChannel(channel, args.GetArgumentArrayRef(),
error_stream))
result.SetStatus(eReturnStatusSuccessFinishNoResult);
- result.GetErrorStream() << error_stream.str();
+ result.GetErrorStream() << error;
}
}
};
@@ -313,7 +313,7 @@ protected:
if (success)
result.SetStatus(eReturnStatusSuccessFinishResult);
}
- result.GetOutputStream() << output_stream.str();
+ result.GetOutputStream() << output;
}
};
class CommandObjectLogDump : public CommandObjectParsed {
@@ -404,7 +404,7 @@ protected:
result.SetStatus(eReturnStatusSuccessFinishNoResult);
} else {
result.SetStatus(eReturnStatusFailed);
- result.GetErrorStream() << error_stream.str();
+ result.GetErrorStream() << error;
}
}