aboutsummaryrefslogtreecommitdiff
path: root/lldb/source/Commands/CommandObjectCommands.cpp
diff options
context:
space:
mode:
authorMartin Storsjo <martin@martin.st>2019-04-26 19:31:39 +0000
committerMartin Storsjo <martin@martin.st>2019-04-26 19:31:39 +0000
commitda93dec330507c5f5ff20115a4d571979ed31393 (patch)
treec05170c984248112ffb902ed8960a06c9677d646 /lldb/source/Commands/CommandObjectCommands.cpp
parentc03fe73176067a2eb2ed5aca8ec685b6ea931b30 (diff)
downloadllvm-da93dec330507c5f5ff20115a4d571979ed31393.zip
llvm-da93dec330507c5f5ff20115a4d571979ed31393.tar.gz
llvm-da93dec330507c5f5ff20115a4d571979ed31393.tar.bz2
[MinGW] Don't let template instantiation declarations cover nested classes
An explicit template instantiation declaration used to let callers assume both outer and nested classes instantiations were defined in a different translation unit. If the instantiation is marked dllexport, only the outer class is exported, but the caller will try to reference the instantiation of both outer and inner classes. This makes MinGW mode match both MSVC and Windows Itanium, by having instantations only cover the outer class, and locally emitting definitions of the nested classes. Windows Itanium was changed to use this behavious in SVN r300804. This deviates from what GCC does, but should be safe (and only inflate the object file size a bit, but MSVC and Windows Itanium modes do the same), and fixes cases where inner classes aren't dllexported. This fixes missing references in combination with dllexported/imported template intantiations. GCC suffers from the same issue, reported at [1], but the issue is still unresolved there. The issue can probably be solved either by making dllexport cover all nested classes as well, or this way (matching MSVC). [1] https://gcc.gnu.org/bugzilla/show_bug.cgi?id=89087 Differential Revision: https://reviews.llvm.org/D61175 llvm-svn: 359342
Diffstat (limited to 'lldb/source/Commands/CommandObjectCommands.cpp')
0 files changed, 0 insertions, 0 deletions