diff options
author | Sanjay Patel <spatel@rotateright.com> | 2019-12-20 17:24:53 -0500 |
---|---|---|
committer | Sanjay Patel <spatel@rotateright.com> | 2019-12-21 10:00:53 -0500 |
commit | 19f9f374d9afe3efd33dc1943d3d7fd2c54fba76 (patch) | |
tree | dd9af18a6f078c3c58dc22417d2b7015f91b1ebc /lldb/source/Commands/CommandObjectCommands.cpp | |
parent | 49b206f95806f35ff8f9a715185355fc2a159760 (diff) | |
download | llvm-19f9f374d9afe3efd33dc1943d3d7fd2c54fba76.zip llvm-19f9f374d9afe3efd33dc1943d3d7fd2c54fba76.tar.gz llvm-19f9f374d9afe3efd33dc1943d3d7fd2c54fba76.tar.bz2 |
[SimplifyLibCalls] require fast-math-flags for pow(X, -0.5) transforms
As discussed in PR44330:
https://bugs.llvm.org/show_bug.cgi?id=44330
...the transform from pow(X, -0.5) libcall/intrinsic to
reciprocal square root can result in small deviations from
the expected result due to differences in the pow()
implementation and/or the extra rounding step from the division.
This patch proposes to allow that difference with either the
'approximate functions' or 'reassociate' FMF:
http://llvm.org/docs/LangRef.html#fast-math-flags
In practice, this likely means that the code is compiled with
all of 'fast' (-ffast-math), but I have preserved the existing
specializations for -0.0/-INF that enable generating safe code
if those special values are allowed simultaneously with
allowing approximation/reassociation.
The question about whether a similar restriction is needed for
the non-reciprocal case -- pow(X, 0.5) -- is deferred. That
transform is allowed without FMF currently, and this patch does
not change that behavior.
Differential Revision: https://reviews.llvm.org/D71706
Diffstat (limited to 'lldb/source/Commands/CommandObjectCommands.cpp')
0 files changed, 0 insertions, 0 deletions