diff options
| author | Miguel A. Arroyo <mayanez@users.noreply.github.com> | 2024-06-04 09:43:24 -0700 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2024-06-04 09:43:24 -0700 |
| commit | 0cb66a7bd52ee51a6b43c42fec22082b26365e37 (patch) | |
| tree | ed1ea6cb922d814f43738432b008eb630bd63830 /lld/test | |
| parent | 188b1a54df9ff6c0b388269c2b95b71a0ae7801b (diff) | |
| download | llvm-0cb66a7bd52ee51a6b43c42fec22082b26365e37.zip llvm-0cb66a7bd52ee51a6b43c42fec22082b26365e37.tar.gz llvm-0cb66a7bd52ee51a6b43c42fec22082b26365e37.tar.bz2 | |
[llvm-readobj][COFF] Consistent PDBGUID Formatting (#94256)
## Consistent PDB GUID in `llvm-readobj`
Currently, the PDB GUID is shown as a byte array:
`PDBGUID: (D8 4C 88 D9 26 15 1F 11 4C 4C 44 20 50 44 42 2E)`
This is inconsistent with `llvm-pdbutil` (e.g. `llvm-pdbutil dump
--summary`) which shows it as a hexadecimal string.
Additionally, `yaml2obj` uses the same hexadecimal string format.
In general, the hexadecimal string is the common representation for PDB
GUIDs on Windows.
This PR changes it to be consistent as shown below:
`PDBGUID: {D9884CD8-1526-111F-4C4C-44205044422E}`
Diffstat (limited to 'lld/test')
| -rw-r--r-- | lld/test/COFF/rsds.test | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/lld/test/COFF/rsds.test b/lld/test/COFF/rsds.test index 3b611c0..babf8cb 100644 --- a/lld/test/COFF/rsds.test +++ b/lld/test/COFF/rsds.test @@ -60,7 +60,7 @@ # CHECK: PointerToRawData: 0x{{[^0]}} # CHECK: PDBInfo { # CHECK: PDBSignature: 0x53445352 -# CHECK: PDBGUID: [[GUID:\(([A-Za-z0-9]{2} ?){16}\)]] +# CHECK: PDBGUID: [[GUID:\{[A-Za-z0-9\-]{36}\}]] # CHECK: PDBAge: 1 # CHECK: PDBFileName: {{.*}}.pdb # CHECK: } @@ -99,7 +99,7 @@ # TWOPDBS: PointerToRawData: 0x{{[^0]}} # TWOPDBS: PDBInfo { # TWOPDBS: PDBSignature: 0x53445352 -# TWOPDBS: PDBGUID: [[GUID:\(([A-Za-z0-9]{2} ?){16}\)]] +# TWOPDBS: PDBGUID: [[GUID:\{[A-Za-z0-9\-]{36}\}]] # TWOPDBS: PDBAge: 1 # TWOPDBS: PDBFileName: {{.*}}.pdb # TWOPDBS: } @@ -182,7 +182,7 @@ # BUILDID: PointerToRawData: 0x{{[^0]}} # BUILDID: PDBInfo { # BUILDID: PDBSignature: 0x53445352 -# BUILDID: PDBGUID: [[GUID:\(([A-Za-z0-9]{2} ?){16}\)]] +# BUILDID: PDBGUID: [[GUID:\{[A-Za-z0-9\-]{36}\}]] # BUILDID: PDBAge: 1 # BUILDID: PDBFileName: # BUILDID: } |