diff options
| author | serge-sans-paille <sguelton@mozilla.com> | 2022-12-26 09:19:09 +0100 |
|---|---|---|
| committer | serge-sans-paille <sguelton@mozilla.com> | 2022-12-27 09:55:19 +0100 |
| commit | d9ab3e82f30d646deff054230b0c742704a1cf26 (patch) | |
| tree | bc1265dff45eb195c81b781bd11a1e3edd0e28bb /lld/MinGW/Driver.cpp | |
| parent | d065472c9ebca5efea7361c229ead7d5cb6f81b5 (diff) | |
| download | llvm-d9ab3e82f30d646deff054230b0c742704a1cf26.zip llvm-d9ab3e82f30d646deff054230b0c742704a1cf26.tar.gz llvm-d9ab3e82f30d646deff054230b0c742704a1cf26.tar.bz2 | |
[clang] Use a StringRef instead of a raw char pointer to store builtin and call information
This avoids recomputing string length that is already known at compile time.
It has a slight impact on preprocessing / compile time, see
https://llvm-compile-time-tracker.com/compare.php?from=3f36d2d579d8b0e8824d9dd99bfa79f456858f88&to=e49640c507ddc6615b5e503144301c8e41f8f434&stat=instructions:u
This a recommit of e953ae5bbc313fd0cc980ce021d487e5b5199ea4 and the subsequent fixes caa713559bd38f337d7d35de35686775e8fb5175 and 06b90e2e9c991e211fecc97948e533320a825470.
The above patchset caused some version of GCC to take eons to compile clang/lib/Basic/Targets/AArch64.cpp, as spotted in aa171833ab0017d9732e82b8682c9848ab25ff9e.
The fix is to make BuiltinInfo tables a compilation unit static variable, instead of a private static variable.
Differential Revision: https://reviews.llvm.org/D139881
Diffstat (limited to 'lld/MinGW/Driver.cpp')
| -rw-r--r-- | lld/MinGW/Driver.cpp | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/lld/MinGW/Driver.cpp b/lld/MinGW/Driver.cpp index cab2d0c..6766f2b 100644 --- a/lld/MinGW/Driver.cpp +++ b/lld/MinGW/Driver.cpp @@ -61,7 +61,10 @@ enum { }; // Create prefix string literals used in Options.td -#define PREFIX(NAME, VALUE) static const char *const NAME[] = VALUE; +#define PREFIX(NAME, VALUE) \ + static constexpr llvm::StringLiteral NAME##_init[] = VALUE; \ + static constexpr llvm::ArrayRef<llvm::StringLiteral> NAME( \ + NAME##_init, std::size(NAME##_init) - 1); #include "Options.inc" #undef PREFIX |