diff options
| author | Mark de Wever <koraq@xs4all.nl> | 2024-03-18 16:53:37 +0100 |
|---|---|---|
| committer | Mark de Wever <koraq@xs4all.nl> | 2024-03-18 17:13:56 +0100 |
| commit | f8042171552ca16e77a5e9367188e7f218474380 (patch) | |
| tree | cedcd2fdd1b60b62918b653f060f973ecdb64f3d /libcxx/utils | |
| parent | 39c739eec9148a2f4e04c7fa9ca11f23db79bb15 (diff) | |
| download | llvm-f8042171552ca16e77a5e9367188e7f218474380.zip llvm-f8042171552ca16e77a5e9367188e7f218474380.tar.gz llvm-f8042171552ca16e77a5e9367188e7f218474380.tar.bz2 | |
Revert "[libc++][CMake] Removes LIBCXX_ENABLE_CLANG_TIDY. (#85262)"
This reverts commit 4109b18ee5de1346c2b89a5c89b86bae5c8631d3.
It looks like the automatic detection has false positives. This broke
the following build https://github.com/llvm/llvm-project/pull/85262
Diffstat (limited to 'libcxx/utils')
| -rw-r--r-- | libcxx/utils/ci/buildkite-pipeline.yml | 1 | ||||
| -rwxr-xr-x | libcxx/utils/ci/run-buildbot | 8 |
2 files changed, 9 insertions, 0 deletions
diff --git a/libcxx/utils/ci/buildkite-pipeline.yml b/libcxx/utils/ci/buildkite-pipeline.yml index 0761b40..e422626 100644 --- a/libcxx/utils/ci/buildkite-pipeline.yml +++ b/libcxx/utils/ci/buildkite-pipeline.yml @@ -43,6 +43,7 @@ definitions: environment_definitions: _common_env: &common_env + ENABLE_CLANG_TIDY: "On" LLVM_SYMBOLIZER_PATH: "/usr/bin/llvm-symbolizer-${LLVM_HEAD_VERSION}" CLANG_CRASH_DIAGNOSTICS_DIR: "crash_diagnostics" CC: clang-${LLVM_HEAD_VERSION} diff --git a/libcxx/utils/ci/run-buildbot b/libcxx/utils/ci/run-buildbot index 10b0ed6..2905745 100755 --- a/libcxx/utils/ci/run-buildbot +++ b/libcxx/utils/ci/run-buildbot @@ -44,6 +44,9 @@ CMAKE The CMake binary to use. This variable is optional. CLANG_FORMAT The clang-format binary to use when generating the format ignore list. +ENABLE_CLANG_TIDY Whether to compile and run clang-tidy checks. This variable + is optional. + EOF } @@ -108,6 +111,10 @@ function clean() { rm -rf "${BUILD_DIR}" } +if [ -z "${ENABLE_CLANG_TIDY}" ]; then + ENABLE_CLANG_TIDY=Off +fi + function generate-cmake-base() { echo "--- Generating CMake" ${CMAKE} \ @@ -119,6 +126,7 @@ function generate-cmake-base() { -DLIBCXX_ENABLE_WERROR=YES \ -DLIBCXXABI_ENABLE_WERROR=YES \ -DLIBUNWIND_ENABLE_WERROR=YES \ + -DLIBCXX_ENABLE_CLANG_TIDY=${ENABLE_CLANG_TIDY} \ -DLLVM_LIT_ARGS="-sv --xunit-xml-output test-results.xml --timeout=1500 --time-tests" \ "${@}" } |