diff options
| author | kadir çetinkaya <kadircet@google.com> | 2024-11-21 12:11:41 +0100 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2024-11-21 12:11:41 +0100 |
| commit | bdd10d9d249bd1c2a45e3de56a5accd97e953458 (patch) | |
| tree | 5d4c81d8e95dfcecaae9fec5e6a52845fd3023d5 /clang/unittests/Serialization/ForceCheckFileInputTest.cpp | |
| parent | 83c7784c35918ce037823f29d29918c5542cdf9c (diff) | |
| download | llvm-bdd10d9d249bd1c2a45e3de56a5accd97e953458.zip llvm-bdd10d9d249bd1c2a45e3de56a5accd97e953458.tar.gz llvm-bdd10d9d249bd1c2a45e3de56a5accd97e953458.tar.bz2 | |
[NFC] Explicitly pass a VFS when creating DiagnosticsEngine (#115852)
Starting with 41e3919ded78d8870f7c95e9181c7f7e29aa3cc4 DiagnosticsEngine
creation might perform IO. It was implicitly defaulting to
getRealFileSystem. This patch makes it explicit by pushing the decision
making to callers.
It uses ambient VFS if one is available, and keeps using
`getRealFileSystem` if there aren't any VFS.
Diffstat (limited to 'clang/unittests/Serialization/ForceCheckFileInputTest.cpp')
| -rw-r--r-- | clang/unittests/Serialization/ForceCheckFileInputTest.cpp | 15 |
1 files changed, 9 insertions, 6 deletions
diff --git a/clang/unittests/Serialization/ForceCheckFileInputTest.cpp b/clang/unittests/Serialization/ForceCheckFileInputTest.cpp index ad8892b..6a839d1 100644 --- a/clang/unittests/Serialization/ForceCheckFileInputTest.cpp +++ b/clang/unittests/Serialization/ForceCheckFileInputTest.cpp @@ -63,12 +63,14 @@ export int aa = 43; std::string BMIPath = llvm::Twine(TestDir + "/a.pcm").str(); { - IntrusiveRefCntPtr<DiagnosticsEngine> Diags = - CompilerInstance::createDiagnostics(new DiagnosticOptions()); CreateInvocationOptions CIOpts; - CIOpts.Diags = Diags; CIOpts.VFS = llvm::vfs::createPhysicalFileSystem(); + IntrusiveRefCntPtr<DiagnosticsEngine> Diags = + CompilerInstance::createDiagnostics(*CIOpts.VFS, + new DiagnosticOptions()); + CIOpts.Diags = Diags; + const char *Args[] = {"clang++", "-std=c++20", "--precompile", "-working-directory", TestDir.c_str(), "a.cppm"}; @@ -103,11 +105,12 @@ export int aa = 43; } { - IntrusiveRefCntPtr<DiagnosticsEngine> Diags = - CompilerInstance::createDiagnostics(new DiagnosticOptions()); CreateInvocationOptions CIOpts; - CIOpts.Diags = Diags; CIOpts.VFS = llvm::vfs::createPhysicalFileSystem(); + IntrusiveRefCntPtr<DiagnosticsEngine> Diags = + CompilerInstance::createDiagnostics(*CIOpts.VFS, + new DiagnosticOptions()); + CIOpts.Diags = Diags; std::string BMIPath = llvm::Twine(TestDir + "/a.pcm").str(); const char *Args[] = { |