diff options
| author | Hamish Knight <hamish_knight@apple.com> | 2023-06-30 16:01:20 -0700 |
|---|---|---|
| committer | Ben Barham <ben_barham@apple.com> | 2023-06-30 16:02:12 -0700 |
| commit | a57bdc8fe68753c341cac0fcecabcd4d35e45466 (patch) | |
| tree | f9b1cdaa5cae8104d2c719dd451d0dc00b91f488 /clang/unittests/Frontend | |
| parent | fc37f717770acdfe5504bb9b969a01bb16a187f9 (diff) | |
| download | llvm-a57bdc8fe68753c341cac0fcecabcd4d35e45466.zip llvm-a57bdc8fe68753c341cac0fcecabcd4d35e45466.tar.gz llvm-a57bdc8fe68753c341cac0fcecabcd4d35e45466.tar.bz2 | |
[clang] Fix leak in LoadFromCommandLineWorkingDirectory unit test
Change `ASTUnit::LoadFromCommandLine` to return a `std::unique_ptr` instead of a +1 pointer, fixing a leak in the unit test `LoadFromCommandLineWorkingDirectory`.
Reviewed By: bnbarham, benlangmuir
Differential Revision: https://reviews.llvm.org/D154257
Diffstat (limited to 'clang/unittests/Frontend')
| -rw-r--r-- | clang/unittests/Frontend/ASTUnitTest.cpp | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/clang/unittests/Frontend/ASTUnitTest.cpp b/clang/unittests/Frontend/ASTUnitTest.cpp index 852cfc7..64fc240 100644 --- a/clang/unittests/Frontend/ASTUnitTest.cpp +++ b/clang/unittests/Frontend/ASTUnitTest.cpp @@ -167,7 +167,7 @@ TEST_F(ASTUnitTest, LoadFromCommandLineEarlyError) { auto PCHContainerOps = std::make_shared<PCHContainerOperations>(); std::unique_ptr<clang::ASTUnit> ErrUnit; - ASTUnit *AST = ASTUnit::LoadFromCommandLine( + std::unique_ptr<ASTUnit> AST = ASTUnit::LoadFromCommandLine( &Args[0], &Args[4], PCHContainerOps, Diags, "", false, "", false, CaptureDiagsKind::All, std::nullopt, true, 0, TU_Complete, false, false, false, SkipFunctionBodiesScope::None, false, true, false, false, @@ -194,7 +194,7 @@ TEST_F(ASTUnitTest, LoadFromCommandLineWorkingDirectory) { auto PCHContainerOps = std::make_shared<PCHContainerOperations>(); std::unique_ptr<clang::ASTUnit> ErrUnit; - auto *AST = ASTUnit::LoadFromCommandLine( + std::unique_ptr<ASTUnit> AST = ASTUnit::LoadFromCommandLine( &Args[0], &Args[4], PCHContainerOps, Diags, "", false, "", false, CaptureDiagsKind::All, std::nullopt, true, 0, TU_Complete, false, false, false, SkipFunctionBodiesScope::None, false, true, false, false, |