diff options
| author | Jan Svoboda <jan_svoboda@apple.com> | 2021-02-26 15:11:11 +0100 |
|---|---|---|
| committer | Jan Svoboda <jan_svoboda@apple.com> | 2021-03-05 10:57:06 +0100 |
| commit | fcf75ae6ce20e3575b1464ce724619f38c43edd2 (patch) | |
| tree | fc7e940ce8da69d5dbe44faed81fc4fc8f8a2e38 /clang/unittests/Frontend/CompilerInvocationTest.cpp | |
| parent | 35908406dc69415de392600bfb93f15865135584 (diff) | |
| download | llvm-fcf75ae6ce20e3575b1464ce724619f38c43edd2.zip llvm-fcf75ae6ce20e3575b1464ce724619f38c43edd2.tar.gz llvm-fcf75ae6ce20e3575b1464ce724619f38c43edd2.tar.bz2 | |
[clang][cli] Fix generation of '-fvisibility' with regards to '-mignore-xcoff-visibility'
This patch fixes failure of the `CodeGen/aix-ignore-xcoff-visibility.cpp` test with command line round-trip.
The absence of '-fvisibility' implies '-mignore-xcoff-visibility'.
The problem is that when '-fvisibility default' is passed to -cc1, it isn't being generated. (This adheres to the principle that generation doesn't produce arguments with default values.)
However, that caused '-mignore-xcoff-visibility' to be implied in the generated command line (without '-fvisibility'), while it wasn't implied in the original command line (with '-fvisibility').
This patch fixes that by always generating '-fvisibility' and explains the situation in comment.
(The '-mginore-xcoff-visibility' option was added in D87451).
Reviewed By: Bigcheese
Differential Revision: https://reviews.llvm.org/D97552
Diffstat (limited to 'clang/unittests/Frontend/CompilerInvocationTest.cpp')
0 files changed, 0 insertions, 0 deletions