Make llvm::StringRef to std::string conversions explicit.

This is how it should've been and brings it more in line with
std::string_view. There should be no functional change here.

This is mostly mechanical from a custom clang-tidy check, with a lot of
manual fixups. It uncovers a lot of minor inefficiencies.

This doesn't actually modify StringRef yet, I'll do that in a follow-up.

1 files changed, 2 insertions, 2 deletions

diff --git a/clang/unittests/Frontend/CompilerInstanceTest.cpp b/clang/unittests/Frontend/CompilerInstanceTest.cpp
index d2377d0..eeae2e9 100644
--- a/clang/unittests/Frontend/CompilerInstanceTest.cpp
+++ b/clang/unittests/Frontend/CompilerInstanceTest.cpp
@@ -32,8 +32,8 @@ TEST(CompilerInstance, DefaultVFSOverlayFromInvocation) {
 
   // Mount the VFS file itself on the path 'virtual.file'. Makes this test
   // a bit shorter than creating a new dummy file just for this purpose.
-  const std::string CurrentPathStr = CurrentPath.str();
-  const std::string FileNameStr = FileName.str();
+  const std::string CurrentPathStr = std::string(CurrentPath.str());
+  const std::string FileNameStr = std::string(FileName.str());
   const char *VFSYaml = "{ 'version': 0, 'roots': [\n"
                         "  { 'name': '%s',\n"
                         "    'type': 'directory',\n"