diff options
| author | Paul Robinson <paul.robinson@sony.com> | 2023-01-26 07:47:37 -0800 |
|---|---|---|
| committer | Paul Robinson <paul.robinson@sony.com> | 2023-01-26 08:40:38 -0800 |
| commit | 787876b0d592a6b4e87d00a0adb89ce87dfc11cd (patch) | |
| tree | 057166e83865dc63146bda792324da56199e04fe /clang/unittests/Driver/ToolChainTest.cpp | |
| parent | 3674421c4bc0cd3b65b8f1feaaf7038ac2d47ca8 (diff) | |
| download | llvm-787876b0d592a6b4e87d00a0adb89ce87dfc11cd.zip llvm-787876b0d592a6b4e87d00a0adb89ce87dfc11cd.tar.gz llvm-787876b0d592a6b4e87d00a0adb89ce87dfc11cd.tar.bz2 | |
[unittests] Use GTEST_SKIP() instead of return when appropriate
Basically NFC: A TEST/TEST_F/etc that bails out early (usually because
setup failed or some other runtime condition wasn't met) generally
should use GTEST_SKIP() to report its status correctly, unless it
takes steps to report another status (e.g., FAIL()).
Diffstat (limited to 'clang/unittests/Driver/ToolChainTest.cpp')
| -rw-r--r-- | clang/unittests/Driver/ToolChainTest.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/clang/unittests/Driver/ToolChainTest.cpp b/clang/unittests/Driver/ToolChainTest.cpp index 068c583..4ddeada 100644 --- a/clang/unittests/Driver/ToolChainTest.cpp +++ b/clang/unittests/Driver/ToolChainTest.cpp @@ -243,7 +243,7 @@ TEST(ToolChainTest, GetTargetAndMode) { llvm::InitializeAllTargets(); std::string IgnoredError; if (!llvm::TargetRegistry::lookupTarget("x86_64", IgnoredError)) - return; + GTEST_SKIP(); ParsedClangName Res = ToolChain::getTargetAndModeFromProgramName("clang"); EXPECT_TRUE(Res.TargetPrefix.empty()); |