diff options
author | Eric Liu <ioeric@google.com> | 2018-07-11 13:15:31 +0000 |
---|---|---|
committer | Eric Liu <ioeric@google.com> | 2018-07-11 13:15:31 +0000 |
commit | 485074f9870020df212d467f56dd26b87d4859df (patch) | |
tree | 226029fe3475e925be159fba84c6e1eef532d6f2 /clang/unittests/Basic/VirtualFileSystemTest.cpp | |
parent | b0d85ef975203006297102795a6fb6fa9b6f163b (diff) | |
download | llvm-485074f9870020df212d467f56dd26b87d4859df.zip llvm-485074f9870020df212d467f56dd26b87d4859df.tar.gz llvm-485074f9870020df212d467f56dd26b87d4859df.tar.bz2 |
[clangd] Ignore sema code complete callback with recovery context.
Summary:
Sema code complete in the recovery mode is generally useless. For many
cases, sema first completes in recovery context and then recovers to more useful
context, in which it's favorable to ignore results from recovery (as results are
often bad e.g. all builtin symbols and top-level symbols). There is also case
where only sema would fail to recover e.g. completions in excluded #if block.
Sema would try to give results, but the results are often useless (see the updated
excluded #if block test).
Reviewers: sammccall, ilya-biryukov
Subscribers: MaskRay, jkorous, cfe-commits
Differential Revision: https://reviews.llvm.org/D49175
llvm-svn: 336801
Diffstat (limited to 'clang/unittests/Basic/VirtualFileSystemTest.cpp')
0 files changed, 0 insertions, 0 deletions