diff options
| author | Pavel Labath <labath@google.com> | 2017-11-09 15:45:09 +0000 |
|---|---|---|
| committer | Pavel Labath <labath@google.com> | 2017-11-09 15:45:09 +0000 |
| commit | 1ebc85f86fd423db1366ba30ec029f19182bd4ea (patch) | |
| tree | 1908bcfd0a09b648255cdad7724072865be15e48 /clang/unittests/Basic/VirtualFileSystemTest.cpp | |
| parent | 818da9bb299cad1a75e5e31dbd96dabb22f54cb8 (diff) | |
| download | llvm-1ebc85f86fd423db1366ba30ec029f19182bd4ea.zip llvm-1ebc85f86fd423db1366ba30ec029f19182bd4ea.tar.gz llvm-1ebc85f86fd423db1366ba30ec029f19182bd4ea.tar.bz2 | |
llgs-tests: Replace the "log+return false" pattern with llvm::Error
Summary:
These tests used to log the error message and return plain bool mainly
because at the time they we written, we did not have a nice way to
assert on llvm::Error values. That is no longer true, so replace this
pattern with a more idiomatic approach.
As a part of this patch, I also move the formatting of
GDBRemoteCommunication::PacketResult values out of the test code, as
that can be useful elsewhere.
Reviewers: zturner, eugene
Subscribers: mgorny, lldb-commits
Differential Revision: https://reviews.llvm.org/D39790
llvm-svn: 317795
Diffstat (limited to 'clang/unittests/Basic/VirtualFileSystemTest.cpp')
0 files changed, 0 insertions, 0 deletions