diff options
author | Nick Zavaritsky <mejedi@gmail.com> | 2024-07-05 17:32:09 +0300 |
---|---|---|
committer | GitHub <noreply@github.com> | 2024-07-05 07:32:09 -0700 |
commit | ae0d2244a23567c8d9863e63b338d34c31416a7b (patch) | |
tree | 7f85bc215e4e722900b305681a8788cd2d0a71cf /clang/test | |
parent | 2bc474b7e6d064d48610594fa5663582126900c4 (diff) | |
download | llvm-ae0d2244a23567c8d9863e63b338d34c31416a7b.zip llvm-ae0d2244a23567c8d9863e63b338d34c31416a7b.tar.gz llvm-ae0d2244a23567c8d9863e63b338d34c31416a7b.tar.bz2 |
[BPF] Fix linking issues in static map initializers (#91310)
When BPF object files are linked with bpftool, every symbol must be
accompanied by BTF info. Ensure that extern functions referenced by
global variable initializers are included in BTF.
The primary motivation is "static" initialization of PROG maps:
```c
extern int elsewhere(struct xdp_md *);
struct {
__uint(type, BPF_MAP_TYPE_PROG_ARRAY);
__uint(max_entries, 1);
__type(key, int);
__type(value, int);
__array(values, int (struct xdp_md *));
} prog_map SEC(".maps") = { .values = { elsewhere } };
```
BPF backend needs debug info to produce BTF. Debug info is not
normally generated for external variables and functions. Previously, it
was solved differently for variables (collecting variable declarations
in ExternalDeclarations vector) and functions (logic invoked during
codegen in CGExpr.cpp).
This patch generalises ExternalDefclarations to include both function
and variable declarations. This change ensures that function references
are not missed no matter the context. Previously external functions
referenced in constant expressions lacked debug info.
Diffstat (limited to 'clang/test')
-rw-r--r-- | clang/test/CodeGen/bpf-debug-info-extern-func.c | 9 | ||||
-rw-r--r-- | clang/test/CodeGen/bpf-debug-info-unref.c | 11 |
2 files changed, 20 insertions, 0 deletions
diff --git a/clang/test/CodeGen/bpf-debug-info-extern-func.c b/clang/test/CodeGen/bpf-debug-info-extern-func.c new file mode 100644 index 0000000..e87c8be --- /dev/null +++ b/clang/test/CodeGen/bpf-debug-info-extern-func.c @@ -0,0 +1,9 @@ +// RUN: %clang -g -target bpf -S -emit-llvm %s -o - | FileCheck %s +// +// When linking BPF object files via bpftool, BTF info is required for +// every symbol. BTF is generated from debug info. Ensure that debug info +// is emitted for extern functions referenced via variable initializers. +// +// CHECK: !DISubprogram(name: "fn" +extern void fn(void); +void (*pfn) (void) = &fn; diff --git a/clang/test/CodeGen/bpf-debug-info-unref.c b/clang/test/CodeGen/bpf-debug-info-unref.c new file mode 100644 index 0000000..91f761e --- /dev/null +++ b/clang/test/CodeGen/bpf-debug-info-unref.c @@ -0,0 +1,11 @@ +// RUN: %clang -g -target bpf -S -emit-llvm %s -o - | FileCheck %s +// +// No debug info is produced for unreferenced functions. +// CHECK-NOT: !DISubprogram +void unref(void); +void unref2(typeof(unref)); + +// No debug info for unused extern variables as well. +// CHECK-NOT: !DiGlobalVariable +extern int unused; +extern int unused2[sizeof(unused)]; |