diff options
author | Aaron Ballman <aaron@aaronballman.com> | 2023-08-28 12:13:42 -0400 |
---|---|---|
committer | Aaron Ballman <aaron@aaronballman.com> | 2023-08-28 12:13:42 -0400 |
commit | 0f1c1be1968076d6f96f8a7bcc4a15cf195ecd97 (patch) | |
tree | 4e5efacb39a74728bca251280e5febfb4a1ac946 /clang/test/Lexer | |
parent | 52683899fcaa45160ba6b669ddd3ec53ce3714f8 (diff) | |
download | llvm-0f1c1be1968076d6f96f8a7bcc4a15cf195ecd97.zip llvm-0f1c1be1968076d6f96f8a7bcc4a15cf195ecd97.tar.gz llvm-0f1c1be1968076d6f96f8a7bcc4a15cf195ecd97.tar.bz2 |
[clang] Remove rdar links; NFC
We have a new policy in place making links to private resources
something we try to avoid in source and test files. Normally, we'd
organically switch to the new policy rather than make a sweeping change
across a project. However, Clang is in a somewhat special circumstance
currently: recently, I've had several new contributors run into rdar
links around test code which their patch was changing the behavior of.
This turns out to be a surprisingly bad experience, especially for
newer folks, for a handful of reasons: not understanding what the link
is and feeling intimidated by it, wondering whether their changes are
actually breaking something important to a downstream in some way,
having to hunt down strangers not involved with the patch to impose on
them for help, accidental pressure from asking for potentially private
IP to be made public, etc. Because folks run into these links entirely
by chance (through fixing bugs or working on new features), there's not
really a set of problematic links to focus on -- all of the links have
basically the same potential for causing these problems. As a result,
this is an omnibus patch to remove all such links.
This was not a mechanical change; it was done by manually searching for
rdar, radar, radr, and other variants to find all the various
problematic links. From there, I tried to retain or reword the
surrounding comments so that we would lose as little context as
possible. However, because most links were just a plain link with no
supporting context, the majority of the changes are simple removals.
Differential Review: https://reviews.llvm.org/D158071
Diffstat (limited to 'clang/test/Lexer')
-rw-r--r-- | clang/test/Lexer/block_cmt_end.c | 2 | ||||
-rw-r--r-- | clang/test/Lexer/comment-escape.c | 1 | ||||
-rw-r--r-- | clang/test/Lexer/constants.c | 1 | ||||
-rw-r--r-- | clang/test/Lexer/counter.c | 1 | ||||
-rw-r--r-- | clang/test/Lexer/ms-extensions.c | 1 | ||||
-rw-r--r-- | clang/test/Lexer/newline-eof.c | 1 | ||||
-rw-r--r-- | clang/test/Lexer/pragma-operators.cpp | 2 | ||||
-rw-r--r-- | clang/test/Lexer/rdar-8914293.c | 1 | ||||
-rw-r--r-- | clang/test/Lexer/rdr-6096838-2.c | 1 | ||||
-rw-r--r-- | clang/test/Lexer/rdr-6096838.c | 1 | ||||
-rw-r--r-- | clang/test/Lexer/utf-16.c | 1 |
11 files changed, 2 insertions, 11 deletions
diff --git a/clang/test/Lexer/block_cmt_end.c b/clang/test/Lexer/block_cmt_end.c index 7d24817..27c6aa8 100644 --- a/clang/test/Lexer/block_cmt_end.c +++ b/clang/test/Lexer/block_cmt_end.c @@ -29,7 +29,7 @@ next comment ends with a trigraph escaped newline: */ foo -// rdar://6060752 - We should not get warnings about trigraphs in comments: +// We should not get warnings about trigraphs in comments: // '????' /* ???? */ diff --git a/clang/test/Lexer/comment-escape.c b/clang/test/Lexer/comment-escape.c index e9851ca..2036055 100644 --- a/clang/test/Lexer/comment-escape.c +++ b/clang/test/Lexer/comment-escape.c @@ -1,5 +1,4 @@ // RUN: %clang -fsyntax-only -Wdocumentation %s -// rdar://6757323 // foo \ #define blork 32 diff --git a/clang/test/Lexer/constants.c b/clang/test/Lexer/constants.c index caa3737..b85eb4a 100644 --- a/clang/test/Lexer/constants.c +++ b/clang/test/Lexer/constants.c @@ -46,7 +46,6 @@ int e = 'abcd'; // still warn: expected-warning {{multi-character character con int f = 'abcd'; // ignored. -// rdar://problem/6974641 float t0[] = { 1.9e20f, 1.9e-20f, diff --git a/clang/test/Lexer/counter.c b/clang/test/Lexer/counter.c index 70ac98e..a7db898 100644 --- a/clang/test/Lexer/counter.c +++ b/clang/test/Lexer/counter.c @@ -1,4 +1,3 @@ -// __COUNTER__ support: rdar://4329310 // RUN: %clang -E %s | FileCheck %s #define PASTE2(x,y) x##y diff --git a/clang/test/Lexer/ms-extensions.c b/clang/test/Lexer/ms-extensions.c index dc7c543..f1eed33 100644 --- a/clang/test/Lexer/ms-extensions.c +++ b/clang/test/Lexer/ms-extensions.c @@ -17,7 +17,6 @@ __complex double c1 = 1i; __complex double c2 = 1.0i; __complex float c3 = 1.0if; -// radar 7562363 #define ULLONG_MAX 0xffffffffffffffffui64 #define UINT 0xffffffffui32 #define USHORT 0xffffui16 diff --git a/clang/test/Lexer/newline-eof.c b/clang/test/Lexer/newline-eof.c index f8471fe..9f50333 100644 --- a/clang/test/Lexer/newline-eof.c +++ b/clang/test/Lexer/newline-eof.c @@ -2,7 +2,6 @@ // RUN: %clang_cc1 -fsyntax-only -pedantic -verify %s // RUN: %clang_cc1 -fsyntax-only -x c++ -std=c++03 -pedantic -verify %s // RUN: %clang_cc1 -fsyntax-only -Wnewline-eof %s 2>&1 | FileCheck %s -// rdar://9133072 // In C++11 mode, this is allowed, so don't warn in pedantic mode. // RUN: %clang_cc1 -fsyntax-only -x c++ -std=c++11 -Wnewline-eof -verify %s diff --git a/clang/test/Lexer/pragma-operators.cpp b/clang/test/Lexer/pragma-operators.cpp index d9c3d36..c202315 100644 --- a/clang/test/Lexer/pragma-operators.cpp +++ b/clang/test/Lexer/pragma-operators.cpp @@ -1,7 +1,7 @@ // RUN: %clang_cc1 -fms-extensions -std=c++11 -E %s -fuse-line-directives | FileCheck %s // Test that we properly expand the C99 _Pragma and Microsoft __pragma -// into #pragma directives, with newlines where needed. <rdar://problem/8412013> +// into #pragma directives, with newlines where needed. // CHECK: #line // CHECK: #pragma warning(push) diff --git a/clang/test/Lexer/rdar-8914293.c b/clang/test/Lexer/rdar-8914293.c index e39e4f1..2d88bc2 100644 --- a/clang/test/Lexer/rdar-8914293.c +++ b/clang/test/Lexer/rdar-8914293.c @@ -1,6 +1,5 @@ // RUN: %clang_cc1 -fsyntax-only -verify %s -// rdar://8914293 // We want be compatible with gcc and warn, not error. /* expected-warning {{missing terminating}} */ #define FOO "foo diff --git a/clang/test/Lexer/rdr-6096838-2.c b/clang/test/Lexer/rdr-6096838-2.c index e64acc9..472a99a 100644 --- a/clang/test/Lexer/rdr-6096838-2.c +++ b/clang/test/Lexer/rdr-6096838-2.c @@ -1,5 +1,4 @@ /* RUN: %clang_cc1 -triple x86_64-unknown-unknown -pedantic -std=gnu89 -fsyntax-only -verify %s - rdar://6096838 */ long double d = 0x0.0000003ffffffff00000p-16357L; /* expected-warning {{hexadecimal floating constants are a C99 feature}} */ diff --git a/clang/test/Lexer/rdr-6096838.c b/clang/test/Lexer/rdr-6096838.c index b77b95e..6072143 100644 --- a/clang/test/Lexer/rdr-6096838.c +++ b/clang/test/Lexer/rdr-6096838.c @@ -1,6 +1,5 @@ /* RUN: %clang_cc1 -triple i386-unknown-unknown -fsyntax-only -verify %s * RUN: %clang_cc1 -triple x86_64-unknown-unknown -std=gnu89 -fsyntax-only -verify %s - rdar://6096838 */ // expected-no-diagnostics diff --git a/clang/test/Lexer/utf-16.c b/clang/test/Lexer/utf-16.c index 169ee43..e8884d8 100644 --- a/clang/test/Lexer/utf-16.c +++ b/clang/test/Lexer/utf-16.c @@ -1,5 +1,4 @@ // RUN: %clang_cc1 %s -fsyntax-only -verify -// rdar://7876588 // This test verifies that clang gives a decent error for UTF-16 source files. |