diff options
| author | Benjamin Kramer <benny.kra@googlemail.com> | 2015-05-29 19:42:19 +0000 |
|---|---|---|
| committer | Benjamin Kramer <benny.kra@googlemail.com> | 2015-05-29 19:42:19 +0000 |
| commit | 3204b152b53e539304f9da2aff100876aeefa856 (patch) | |
| tree | 413a942366f5a46724c5658daf847ee3493e9f5e /clang/lib/Tooling/JSONCompilationDatabase.cpp | |
| parent | 36cbc0901f7a8ac02511143f1b5e4b6478221239 (diff) | |
| download | llvm-3204b152b53e539304f9da2aff100876aeefa856.zip llvm-3204b152b53e539304f9da2aff100876aeefa856.tar.gz llvm-3204b152b53e539304f9da2aff100876aeefa856.tar.bz2 | |
Replace push_back(Constructor(foo)) with emplace_back(foo) for non-trivial types
If the type isn't trivially moveable emplace can skip a potentially
expensive move. It also saves a couple of characters.
Call sites were found with the ASTMatcher + some semi-automated cleanup.
memberCallExpr(
argumentCountIs(1), callee(methodDecl(hasName("push_back"))),
on(hasType(recordDecl(has(namedDecl(hasName("emplace_back")))))),
hasArgument(0, bindTemporaryExpr(
hasType(recordDecl(hasNonTrivialDestructor())),
has(constructExpr()))),
unless(isInTemplateInstantiation()))
No functional change intended.
llvm-svn: 238601
Diffstat (limited to 'clang/lib/Tooling/JSONCompilationDatabase.cpp')
| -rw-r--r-- | clang/lib/Tooling/JSONCompilationDatabase.cpp | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/clang/lib/Tooling/JSONCompilationDatabase.cpp b/clang/lib/Tooling/JSONCompilationDatabase.cpp index 7dc211e..454a2ff 100644 --- a/clang/lib/Tooling/JSONCompilationDatabase.cpp +++ b/clang/lib/Tooling/JSONCompilationDatabase.cpp @@ -220,10 +220,10 @@ void JSONCompilationDatabase::getCommands( for (int I = 0, E = CommandsRef.size(); I != E; ++I) { SmallString<8> DirectoryStorage; SmallString<1024> CommandStorage; - Commands.push_back(CompileCommand( - // FIXME: Escape correctly: - CommandsRef[I].first->getValue(DirectoryStorage), - unescapeCommandLine(CommandsRef[I].second->getValue(CommandStorage)))); + Commands.emplace_back( + // FIXME: Escape correctly: + CommandsRef[I].first->getValue(DirectoryStorage), + unescapeCommandLine(CommandsRef[I].second->getValue(CommandStorage))); } } |