diff options
| author | Jan Svoboda <jan_svoboda@apple.com> | 2023-01-19 17:02:42 -0800 |
|---|---|---|
| committer | Jan Svoboda <jan_svoboda@apple.com> | 2023-01-20 13:37:36 -0800 |
| commit | c3efd52770ca964ba46287298c1d2f7697fd446c (patch) | |
| tree | ba336fee3953bfb00a7c8bbacb6764b85a415770 /clang/lib/Sema/SemaModule.cpp | |
| parent | 743fbcb79d9af759377df5f5929ffdd38ff52b09 (diff) | |
| download | llvm-c3efd52770ca964ba46287298c1d2f7697fd446c.zip llvm-c3efd52770ca964ba46287298c1d2f7697fd446c.tar.gz llvm-c3efd52770ca964ba46287298c1d2f7697fd446c.tar.bz2 | |
[clang][modules] Disallow importing private framework in the implementation
Whenever we are compiling implementation of a framework (with the `-fmodule-name=FW` option), we never translate `#import <FW/Header.h>` to an import, regardless of whether "Header.h" belongs to "FW" or "FW_Private". For the same reasons, we also disallow `@import FW`. However, we still allow `@import FW_Private`. This patch disallows that a well, to be consistent with the rest of the rules.
Reviewed By: benlangmuir
Differential Revision: https://reviews.llvm.org/D142167
Diffstat (limited to 'clang/lib/Sema/SemaModule.cpp')
| -rw-r--r-- | clang/lib/Sema/SemaModule.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/clang/lib/Sema/SemaModule.cpp b/clang/lib/Sema/SemaModule.cpp index 8fa31ea..823a4e9 100644 --- a/clang/lib/Sema/SemaModule.cpp +++ b/clang/lib/Sema/SemaModule.cpp @@ -541,7 +541,7 @@ DeclResult Sema::ActOnModuleImport(SourceLocation StartLoc, // of the same top-level module. Until we do, make it an error rather than // silently ignoring the import. // FIXME: Should we warn on a redundant import of the current module? - if (Mod->getTopLevelModuleName() == getLangOpts().CurrentModule && + if (Mod->isForBuilding(getLangOpts()) && (getLangOpts().isCompilingModule() || !getLangOpts().ModulesTS)) { Diag(ImportLoc, getLangOpts().isCompilingModule() ? diag::err_module_self_import |