diff options
| author | Manna, Soumi <soumi.manna@intel.com> | 2023-05-23 07:07:09 -0700 |
|---|---|---|
| committer | Manna, Soumi <soumi.manna@intel.com> | 2023-05-23 07:10:44 -0700 |
| commit | 7586aeab7ad3fb035752eea89fd2bb895de21143 (patch) | |
| tree | d6593f94845c5e9245a801822d6cc37faa2053b9 /clang/lib/Sema/SemaExprMember.cpp | |
| parent | 28776d501cad38d56b8e05ba1ec5044c88901d7a (diff) | |
| download | llvm-7586aeab7ad3fb035752eea89fd2bb895de21143.zip llvm-7586aeab7ad3fb035752eea89fd2bb895de21143.tar.gz llvm-7586aeab7ad3fb035752eea89fd2bb895de21143.tar.bz2 | |
[NFC][CLANG] Fix static code analyzer concerns with dereference null return value
Reported by Static Code Analyzer Tool, Coverity:
Inside "SemaExprMember.cpp" file, in clang::Sema::BuildMemberReferenceExpr(clang::Expr *, clang::QualType, clang::SourceLocation, bool, clang::CXXScopeSpec &, clang::SourceLocation, clang::NamedDecl *, clang::DeclarationNameInfo const &, clang::TemplateArgumentListInfo const *, clang::Scope const *, clang::Sema::ActOnMemberAccessExtraArgs *): Return value of function which returns null is dereferenced without checking
//Condition !Base, taking true branch.
if (!Base) {
TypoExpr *TE = nullptr;
QualType RecordTy = BaseType;
//Condition IsArrow, taking true branch.
if (IsArrow) RecordTy = RecordTy->castAs<PointerType>()->getPointeeType();
//returned_null: getAs returns nullptr (checked 279 out of 294 times).
//Condition TemplateArgs != NULL, taking true branch.
//Dereference null return value (NULL_RETURNS)
//dereference: Dereferencing a pointer that might be nullptr RecordTy->getAs() when calling LookupMemberExprInRecord.
if (LookupMemberExprInRecord(
*this, R, nullptr, RecordTy->getAs<RecordType>(), OpLoc, IsArrow,
SS, TemplateArgs != nullptr, TemplateKWLoc, TE))
return ExprError();
if (TE)
return TE;
This patch uses castAs instead of getAs which will assert if the type doesn't match.
Reviewed By: erichkeane
Differential Revision: https://reviews.llvm.org/D151130
Diffstat (limited to 'clang/lib/Sema/SemaExprMember.cpp')
| -rw-r--r-- | clang/lib/Sema/SemaExprMember.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/clang/lib/Sema/SemaExprMember.cpp b/clang/lib/Sema/SemaExprMember.cpp index 60b9b01..3d14ca3 100644 --- a/clang/lib/Sema/SemaExprMember.cpp +++ b/clang/lib/Sema/SemaExprMember.cpp @@ -767,7 +767,7 @@ Sema::BuildMemberReferenceExpr(Expr *Base, QualType BaseType, QualType RecordTy = BaseType; if (IsArrow) RecordTy = RecordTy->castAs<PointerType>()->getPointeeType(); if (LookupMemberExprInRecord( - *this, R, nullptr, RecordTy->getAs<RecordType>(), OpLoc, IsArrow, + *this, R, nullptr, RecordTy->castAs<RecordType>(), OpLoc, IsArrow, SS, TemplateArgs != nullptr, TemplateKWLoc, TE)) return ExprError(); if (TE) |